Skip to content

UX: sidebar btn light dark support horizon #34319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025

Conversation

dbattersby
Copy link
Contributor

@dbattersby dbattersby commented Aug 14, 2025

Fixes some small inconsistencies between light and dark modes and small tidyups:

  1. hover effect in dark mode is different for button and dropdown (matches correctly on light mode)
  2. split button divider line disappears when hovering button but not dropdown arrow (we do remove border opacity for regular buttons for split buttons we should probably keep it)
  3. divider line color could be better on dark mode

Before

Example with forced hover state on both button and dropdown arrow (see point 1):
Screenshot 2025-08-14 at 12 39 24 PM

After

Screen.Recording.2025-08-14.at.12.33.10.PM.mov

@dbattersby dbattersby force-pushed the light-dark-support-sidebar-topic-btn branch from 3e1f495 to 194f5cc Compare August 14, 2025 09:00
@dbattersby dbattersby merged commit dd0a5c3 into main Aug 14, 2025
18 checks passed
@dbattersby dbattersby deleted the light-dark-support-sidebar-topic-btn branch August 14, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants