DEV: Replace <Input /> text usage in plugins #34352
Merged
+181
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces usage of the Ember `<Input />` component with native `<input>` elements in core plugins for text and number inputs. Generated with claude.
CvX
reviewed
Aug 18, 2025
There was a problem hiding this comment.
A general note about transforming those:
Input component is adding (among other things) a .ember-text-field class to these inputs. I see we use that class in css in core and in custom plugins. Those styles will need to be updated to e.g. also include [type="text"], [type="number"], etc. (when needed)
(not sure if any of those affect inputs modified in this PR)
...ripts/discourse/templates/admin/plugins-discourse-subscriptions-products-show-plans-show.gjs
Outdated
Show resolved
Hide resolved
...ripts/discourse/templates/admin/plugins-discourse-subscriptions-products-show-plans-show.gjs
Outdated
Show resolved
Hide resolved
CvX
approved these changes
Aug 19, 2025
yuriyaran
pushed a commit
that referenced
this pull request
Aug 21, 2025
Replaces usage of the Ember `<Input />` component with native `<input>` elements in core plugins for text and number inputs. Generated with claude.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces usage of the Ember
<Input />component withnative
<input>elements in core plugins for text andnumber inputs.
Generated with claude.