Fixed #35831 -- Documented the model form meta API in model form reference docs. #19758
Conversation
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
There was a problem hiding this comment.
Thank you for picking this up @mspirbhai !
Once you have reverted the changes in docs/conf.py, can you squash to a single commit with yourself and @jernwerber as the co-author?
I have re-read through and tried to make suggestions with the following in mind:
- consistency of phrasing
- "less is more": occasionally there were references around potential errors raised when not configured correctly. I have sometimes opted to remove this and focus on documenting how to configure correctly.
I have broken up these suggestions so if you disagree with any of the changes, shout 👍
fe3bbd6 to
efee3af
Compare
…rence docs. Co-authored-by: Jonathan <3218047+jernwerber@users.noreply.github.com> Co-authored-by: Mustafa <117516335+mspirbhai@users.noreply.github.com>
efee3af to
4158a7d
Compare
|
Thank you 😃 |
|
Nothing substantive to add, but I just wanted to say that I appreciate @mspirbhai & @sarahboyce putting the effort in to get this across the line (when it completely dropped off my radar 😅)! |
Trac ticket number
ticket-35831
Branch description
Follow up on @jernwerber work on the ticket from PR #18699.
Checklist
mainbranch.