Skip to content

Conversation

jacobtylerwalls
Copy link
Member

When triaging, I've never been sure how to use the version field in Trac. I believe I've seen issues affecting main and 4.2 be be bumped from 4.2 -> dev or from dev -> 4.2 by triagers. It would be nice to settle on a practice and doc it.

I polled the current fellows today, and it seems the highest value from this field is being able to filter on release blockers for a version, e.g. 5.2, and so for that purpose, it helps for the version to be set to the earliest supported version.

Clarified this below.
Left a couple notes to discourage:

  • noisy updates from 4.2 -> 5.2 after 4.2 goes out of support
  • unnecessary updates to "dev"

@github-actions github-actions bot added the no ticket Based on PR title, no linked Trac ticket label Aug 25, 2025
Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added a alternative, let me know what you think.

@nessita
Copy link
Contributor

nessita commented Aug 26, 2025

I would also suggest adjusting the commit message to give a hint of where this update occurred, for example:

Clarified Trac "version" attribute semantic in contributing guide.

@jacobtylerwalls jacobtylerwalls force-pushed the version-attribute branch 2 times, most recently from fa6e700 to f08be74 Compare August 26, 2025 21:29
@jacobtylerwalls jacobtylerwalls changed the title Clarified description of Version attribute in Trac. Clarified Trac "version" attribute in contributing guide. Aug 26, 2025
@jacobtylerwalls jacobtylerwalls merged commit c594574 into django:main Aug 26, 2025
13 of 26 checks passed
@jacobtylerwalls jacobtylerwalls deleted the version-attribute branch August 26, 2025 21:49
@ulgens
Copy link
Member

ulgens commented Aug 28, 2025

Do we have a non-internal information about the issue fields? I always thought this field indicates which version the issue targets, and had no idea it was about where it can be reproduced.

@jacobtylerwalls
Copy link
Member Author

In short, no, unless there is information in Trac's wiki.

Happy to clarify further, what does "targets" convey in this context?

@ulgens
Copy link
Member

ulgens commented Aug 28, 2025

Happy to clarify further

what does "targets" convey in this context?

I'm not sure what the correct term is or how this is defined in different software, but I was acknowledging it as "This will be fixed in version x" (similar to Jira's take on the field). When I see an older version, my thinking was "oh this was originally targeted to 3.2, but now we have 5.2 and it should be updated". My expectation for the default value was the latest main (I guess we call it "dev" in this context)

@jacobtylerwalls
Copy link
Member Author

Ah, makes sense. I think a notion of "targeting" makes more sense in other development workflows than ours, with stricter roadmaps. With our volunteer-driven, time-based release process, we do very little "targeting"; instead things land when they're ready.

When I see an older version, my thinking was "oh this was originally targeted to 3.2, but now we have 5.2 and it should be updated"

Instead, I think features and optimizations should just be set to dev, but bugs can be marked with a version to help us reason about whether or not they're recent regressions that qualify for a backport. My hope is that makes things clear, helpful for filtering, and reduces frequency of updates in Trac.

@ulgens
Copy link
Member

ulgens commented Aug 30, 2025

With our volunteer-driven, time-based release process, we do very little "targeting"; instead things land when they're ready.

I think features and optimizations should just be set to dev, but bugs can be marked with a version to help us reason about whether or not they're recent regressions that qualify for a backport.

I'm not sure I agree or disagree with these points, but I'm even more sure that what we use that field for is a bit different from the standard, and it needs a better explanation for a (non-triager) user who is checking Trac .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no ticket Based on PR title, no linked Trac ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants