Skip to content

Fine tune postgis GHA (see commits). #19785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2025
Merged

Fine tune postgis GHA (see commits). #19785

merged 2 commits into from
Aug 27, 2025
+10 −4

Conversation

nessita
Copy link
Contributor

@nessita nessita commented Aug 27, 2025

No description provided.

@github-actions github-actions bot added the no ticket Based on PR title, no linked Trac ticket label Aug 27, 2025
@nessita nessita force-pushed the gha-postgis-update-apt branch from 5828e9d to 62d877c Compare August 27, 2025 12:35
@nessita
Copy link
Contributor Author

nessita commented Aug 27, 2025

Second commits allows to run postgis tests with:

  • latest stable in debian:
    • POSTGIS="3.5.2 dea6d0a"
    • GEOS="3.9.0-CAPI-1.16.2"
    • PROJ="7.2.1"
  • latest stable in alpine:
    • POSTGIS="3.5.3 0"
    • GEOS="3.13.1-CAPI-1.19.2"
    • PROJ="9.6.0
  • latest development branch:
    • POSTGIS="3.6.0dev 3.6.0beta1-29-g7c8cfe07d"
    • GEOS="3.14.0beta2-CAPI-1.20.1"
    • PROJ="9.7.0"

jacobtylerwalls
jacobtylerwalls approved these changes Aug 27, 2025
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that extra info in your comment helps me understand why we need both latest and 17-3.5-alpine. Fancy a one sentence extended commit msg explaining that latest/debian may not have same GEOS version as alpine?

Testing against postgis bleeding-edge feels warranted given that we have this action guarded under a label, and I take it we're the type of project that image was made for.

@nessita
Copy link
Contributor Author

nessita commented Aug 27, 2025

Thanks, that extra info in your comment helps me understand why we need both latest and 17-3.5-alpine. Fancy a one sentence extended commit msg explaining that latest/debian may not have same GEOS version as alpine?

Yes, good call! Also, for future reference, the action prints the version right after installing the geolibs and before running the tests, so if we have failures, we can more easily see which versions were used:
image

@nessita
Copy link
Contributor Author

nessita commented Aug 27, 2025

When CI is green I'll push the amended commit and land:

commit 676bc6adafefe8e83a6b676782250829f71586b7 (HEAD -> gha-postgis-update-apt)
Author: Natalia <124304+nessita@users.noreply.github.com>
Date:   Wed Aug 27 09:15:16 2025 -0300

    Added matrix with newer image versions to the "postgis" GitHub Action.
    
    This work allows to test three types of postgis Docker images to cover
    a wider spectrum of geo libraries versions:
    
    * `latest` (recommended upstream): uses latest stable Debian packages.
      These versions are generally conservative, so they may lag behind.
    * `alpine`: build PostGIS from source on Alpine, and ship newer
      geospatial libs.
    * `master`: provides development versions, therefore coverage for what's
      coming. Future compatibility issues can be caught in advance.
    
    This split is important because each image differ significantly in
    GEOS/PROJ/GDAL versions, so testing all increases confidence in
    compatibility. More info at https://hub.docker.com/r/postgis/postgis/.
    
    For example, at the time of this branch:
    
    * latest stable in debian:
      * POSTGIS="3.5.2 dea6d0a"
      * GEOS="3.9.0-CAPI-1.16.2"
      * PROJ="7.2.1"
    * latest stable in alpine:
      * POSTGIS="3.5.3 0"
      * GEOS="3.13.1-CAPI-1.19.2"
      * PROJ="9.6.0
    * latest development branch:
      * POSTGIS="3.6.0dev 3.6.0beta1-29-g7c8cfe07d"
      * GEOS="3.14.0beta2-CAPI-1.20.1"
      * PROJ="9.7.0"

@nessita nessita mentioned this pull request Aug 27, 2025
Merged
6 tasks
@nessita nessita force-pushed the gha-postgis-update-apt branch from 62d877c to 676bc6a Compare August 27, 2025 13:27
@jacobtylerwalls
Copy link
Member

lgtm, save for "each image differ" -> "each image differs"

@nessita
Added matrix with newer image versions to the "postgis" GitHub Action.
7b50e3f 
This work allows to test three types of postgis Docker images to cover
a wider spectrum of geo libraries versions:

* `latest` (recommended upstream): uses latest stable Debian packages.
  These versions are generally conservative, so they may lag behind.
* `alpine`: build PostGIS from source on Alpine, and ship newer
  geospatial libs.
* `master`: provides development versions, therefore coverage for what's
  coming. Future compatibility issues can be caught in advance.

This split is important because each image differs significantly in
GEOS/PROJ/GDAL versions, so testing all increases confidence in
compatibility. More info at https://hub.docker.com/r/postgis/postgis/.

For example, at the time of this branch:

* latest stable in debian:
  * POSTGIS="3.5.2 dea6d0a"
  * GEOS="3.9.0-CAPI-1.16.2"
  * PROJ="7.2.1"
* latest stable in alpine:
  * POSTGIS="3.5.3 0"
  * GEOS="3.13.1-CAPI-1.19.2"
  * PROJ="9.6.0
* latest development branch:
  * POSTGIS="3.6.0dev 3.6.0beta1-29-g7c8cfe07d"
  * GEOS="3.14.0beta2-CAPI-1.20.1"
  * PROJ="9.7.0"
@nessita nessita force-pushed the gha-postgis-update-apt branch from 676bc6a to 7b50e3f Compare August 27, 2025 13:32
@nessita nessita merged commit 4f07767 into django:main Aug 27, 2025
34 checks passed
@nessita nessita deleted the gha-postgis-update-apt branch August 27, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
geodjango no ticket Based on PR title, no linked Trac ticket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nessita @jacobtylerwalls