-
-
Notifications
You must be signed in to change notification settings - Fork 32.9k
Fixed incorrect IDs in test_in_bulk_preserve_ordering. #19786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed incorrect IDs in test_in_bulk_preserve_ordering. #19786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Did a quick sanity check that after this update the test still fails if the code regresses.
@timgraham I noticed there's a similar |
I changed it at first before realizing that test uses |
But I think it's still supposed be an |
e32dcce
to
22aaf18
Compare
22aaf18
to
49ea5d5
Compare
When you specify |
Yep, but we're querying |
We have
Or it could be written (
(One and two letter variable names don't help!!) |
Thanks for the catch and the patient explanations! 🎯 |
au
objects are authors, not articles. Failure observed on MongoDB after d3cf24e which removed the skipping of this test.