Skip to content

Fixed #36264 -- Excluded proxy neighbors of parents from deletion collection when keep_parents=True. #19800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed #36264 -- Excluded proxy neighbors of parents from deletion collection when keep_parents=True. #19800

wants to merge 1 commit into from
+19 −2

Conversation

JaeHyuckSa
Copy link
Contributor

Trac ticket number

ticket-36264

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

charettes
charettes reviewed Sep 2, 2025
View reviewed changes
Copy link
Member

@charettes charettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corrective is right but the test could do with a bit of model reuse.

@JaeHyuckSa
Fixed #36264 -- Excluded proxy neighbors of parents from deletion col…
10dd435 
…lection when keep_parents=True.

Signed-off-by: saJaeHyukc <wogur981208@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@charettes charettes charettes left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaeHyuckSa @charettes