Skip to content

Conversation

ZzZombo
Copy link
Contributor

@ZzZombo ZzZombo commented Sep 1, 2025

Summary

This PR fixes spelling mistakes.


Internal previews

📄 File 🔗 Preview link
docs/core/compatibility/sdk/8.0/custombuildeventargs.md MSBuild custom derived build events deprecated

@ZzZombo ZzZombo requested review from gewarren and a team as code owners September 1, 2025 09:50
@dotnetrepoman dotnetrepoman bot added this to the September 2025 milestone Sep 1, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Sep 1, 2025
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZzZombo

@gewarren gewarren enabled auto-merge (squash) September 2, 2025 00:14
@gewarren gewarren merged commit 6f4dab8 into dotnet:main Sep 2, 2025
11 checks passed
@ZzZombo ZzZombo deleted the patch-1 branch September 3, 2025 01:39
@ZzZombo
Copy link
Contributor Author

ZzZombo commented Sep 4, 2025

@gewarren, if you don't mind, do you know where is the referenced error message (quoted in the article) defined? It contains the same "unsecure" typo.

@gewarren
Copy link
Contributor

gewarren commented Sep 4, 2025

@gewarren, if you don't mind, do you know where is the referenced error message (quoted in the article) defined? It contains the same "unsecure" typo.

@ZzZombo Looks like it no longer contains the word "unsecure":

https://github.com/dotnet/msbuild/pull/11346/files#diff-c7dca4082a1c8d4a5266ea02ca9e78e6104f37b6039474e9f7b734e972f56f4f

I wonder if we should update the article to include the new error message as well...

@ZzZombo
Copy link
Contributor Author

ZzZombo commented Sep 5, 2025

It seems logical, so I'm all for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants