Refactor dashboard automation tests and improve configuration handling #4238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Refactors the .NET Aspire dashboard automation tests to improve configuration handling and fix various issues with test stability and reliability.
- Improved configuration value retrieval with default fallback values
- Enhanced URL resolution using proper event-driven mechanisms
- Increased test timeout and improved error handling for better reliability
Reviewed Changes
Copilot reviewed 8 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
Program.cs |
Updated configuration value retrieval to use overload with default value |
PlaywrightTestsBase.cs |
Refactored URL resolution using event-driven approach and added error handling |
PlaywrightFixture.cs |
Increased default timeout from 10 to 30 seconds |
FluentDataGridSelector.cs |
Added debugger display attribute for better debugging experience |
PageExtensions.cs |
Enhanced login method with network idle wait condition |
DashboardSelectors.cs |
Updated selector to handle both C: and E: drive paths |
CaptureImages.cs |
Simplified test code and improved reliability with forced clicks |
AppHostTestFixture.cs |
Improved configuration handling and added unsecured transport option |
.../dashboard/automation/aspire-dashboard/Aspire.Dashboard.ScreenCapture/PlaywrightTestsBase.cs
Outdated
Show resolved
Hide resolved
...shboard/automation/aspire-dashboard/Aspire.Dashboard.ScreenCapture/FluentDataGridSelector.cs
Show resolved
Hide resolved
...shboard/automation/aspire-dashboard/Aspire.Dashboard.ScreenCapture/FluentDataGridSelector.cs
Show resolved
Hide resolved
...entals/dashboard/automation/aspire-dashboard/Aspire.Dashboard.ScreenCapture/CaptureImages.cs
Outdated
Show resolved
Hide resolved
adegeo
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor dashboard automation tests and improve configuration handling
Fixes #4237