[cDAC] implement IXCLRDataMethodInstance::GetILAddressMap #119019
Merged
+94
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
There was a problem hiding this comment.
Pull Request Overview
This PR implements the IXCLRDataMethodInstance::GetILAddressMap method in the cDAC (Contract-based Debug Access Component) system. The implementation replaces a stub that previously delegated to the legacy implementation with a full native implementation that retrieves IL-to-native address mapping information for debugging purposes.
Key Changes:
- Defines new data structures (
ClrDataSourceTypeenum andClrDataILAddressMapstruct) for IL address mapping - Implements the
GetILAddressMapmethod to provide IL offset to native address mappings using the target contracts - Adds comprehensive debug validation to compare cDAC results with legacy DAC implementation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| IXCLRData.cs | Defines new IL address mapping data structures and updates method signature with proper marshaling attributes |
| ClrDataMethodInstance.cs | Implements GetILAddressMap method with native code retrieval, offset mapping, and debug validation |
src/native/managed/cdac/mscordaccore_universal/Legacy/ClrDataMethodInstance.cs
Show resolved
Hide resolved
src/native/managed/cdac/mscordaccore_universal/Legacy/ClrDataMethodInstance.cs
Show resolved
Hide resolved
src/native/managed/cdac/mscordaccore_universal/Legacy/ClrDataMethodInstance.cs
Show resolved
Hide resolved
noahfalk
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.