NTP: Set target to 'new-tab' and 'new-window' properly when submitting Omnibar #1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
searches and chats
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Tue, 15 Jul 2025 09:40:02 GMT IntegrationFile has changed WindowsFile has changed AppleFile has changed |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
shakyShane
approved these changes
Jul 15, 2025
mallexxx
pushed a commit
that referenced
this pull request
Jul 17, 2025
…g Omnibar (#1824) * Set target to 'new-tab' and 'new-window' properly when submitting searches and chats * Simplify omnibar tests to use only cmd (Meta) key modifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1210783311211753?focus=true
Description
targetinomnibar_submitSearchandomnibar_submitChatshould benew-windowif shift is held down ornew-tabif cmd is held down.Testing Steps
Tests are included. You can manually verify by loading https://deploy-preview-1824--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar=true and inspecting the
targetfield of the payload in theomnibar_submitSearchandomnibar_submitSearchnotifications that are logged in DevTools when submitting the Search or Duck.ai inputs.Checklist
Please tick all that apply: