Skip to content

NTP: Omnibar i18n #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2025
Merged

NTP: Omnibar i18n #1827

merged 2 commits into from
Jul 16, 2025

Conversation

noisysocks
Copy link
Contributor

@noisysocks noisysocks commented Jul 16, 2025 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1210691689624304

Description

Adds translated strings for the omnibar widget.

Testing Steps

Browse to https://deploy-preview-1827--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar=true&locale=es. Replace es with whichever locale you want to test.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@noisysocks noisysocks requested a review from shakyShane as a code owner July 16, 2025 01:24
@noisysocks noisysocks added the enhancement New feature or request label Jul 16, 2025
@noisysocks noisysocks requested review from mgurgel and a team as code owners July 16, 2025 01:24
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2025 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit a8b4776
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6876ff3913072a0008876b39
😎 Deploy Preview https://deploy-preview-1827--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions GitHub Actions
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

[Beta] Generated file diff

Time updated: Wed, 16 Jul 2025 01:25:06 GMT

Integration 
    - integration/pages/new-tab/dist/index.js
  • integration/pages/new-tab/locales/de/new-tab.json
  • integration/pages/new-tab/locales/en/new-tab.json
  • integration/pages/new-tab/locales/es/new-tab.json
  • integration/pages/new-tab/locales/fr/new-tab.json
  • integration/pages/new-tab/locales/it/new-tab.json
  • integration/pages/new-tab/locales/nl/new-tab.json
  • integration/pages/new-tab/locales/pl/new-tab.json
  • integration/pages/new-tab/locales/pt/new-tab.json
  • integration/pages/new-tab/locales/ru/new-tab.json

File has changed

Windows 
    - windows/pages/new-tab/dist/index.js
  • windows/pages/new-tab/locales/de/new-tab.json
  • windows/pages/new-tab/locales/en/new-tab.json
  • windows/pages/new-tab/locales/es/new-tab.json
  • windows/pages/new-tab/locales/fr/new-tab.json
  • windows/pages/new-tab/locales/it/new-tab.json
  • windows/pages/new-tab/locales/nl/new-tab.json
  • windows/pages/new-tab/locales/pl/new-tab.json
  • windows/pages/new-tab/locales/pt/new-tab.json
  • windows/pages/new-tab/locales/ru/new-tab.json

File has changed

Apple 
    - dist/pages/new-tab/dist/index.js
  • dist/pages/new-tab/locales/de/new-tab.json
  • dist/pages/new-tab/locales/en/new-tab.json
  • dist/pages/new-tab/locales/es/new-tab.json
  • dist/pages/new-tab/locales/fr/new-tab.json
  • dist/pages/new-tab/locales/it/new-tab.json
  • dist/pages/new-tab/locales/nl/new-tab.json
  • dist/pages/new-tab/locales/pl/new-tab.json
  • dist/pages/new-tab/locales/pt/new-tab.json
  • dist/pages/new-tab/locales/ru/new-tab.json

File has changed

@noisysocks noisysocks merged commit 4ed322e into main Jul 16, 2025
20 checks passed
@noisysocks noisysocks deleted the randerson/omnibar-i18n branch July 16, 2025 10:56
mallexxx pushed a commit that referenced this pull request Jul 17, 2025
@noisysocks
NTP: Omnibar i18n (#1827)
bc22632 
* Prefix omnibar translation keys for consistency

* Add omnibar translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakyShane shakyShane shakyShane approved these changes

@mgurgel mgurgel Awaiting requested review from mgurgel mgurgel is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noisysocks @shakyShane