Skip to content

NTP: Omnibar suffix text #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

NTP: Omnibar suffix text #1831

wants to merge 18 commits into from

Conversation

noisysocks
Copy link
Contributor

@noisysocks noisysocks commented Jul 17, 2025 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1210735524372722

Description

Screenshot 2025-07-18 at 09 37 02

Implements:

  • Suffix text (text shown after an en dash) for the input
  • Suffix text for suggestions
  • “Switch to Tab” badge for tab suggestions

Testing Steps

Browse to https://deploy-preview-1831--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar=true and search for “pizza".

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@noisysocks noisysocks added the enhancement New feature or request label Jul 17, 2025
@noisysocks noisysocks requested review from shakyShane, mgurgel and a team as code owners July 17, 2025 23:40
@netlify Netlify
Copy link

netlify bot commented Jul 17, 2025 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit db9773a
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68799195b703000008fd4c75
😎 Deploy Preview https://deploy-preview-1831--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2025 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2025 •
edited
Loading

[Beta] Generated file diff

Time updated: Fri, 18 Jul 2025 00:15:32 GMT

Integration 
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js
  • integration/pages/new-tab/locales/en/new-tab.json

File has changed

Windows 
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js
  • windows/pages/new-tab/locales/en/new-tab.json

File has changed

Apple 
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js
  • dist/pages/new-tab/locales/en/new-tab.json

File has changed

cursor[bot]

This comment was marked as outdated.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@shakyShane shakyShane Awaiting requested review from shakyShane shakyShane is a code owner

@mgurgel mgurgel Awaiting requested review from mgurgel mgurgel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@noisysocks