Skip to content

NTP: Add Duck.ai toggle to Customize drawer #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

NTP: Add Duck.ai toggle to Customize drawer #1832

wants to merge 3 commits into from

Conversation

noisysocks
Copy link
Contributor

@noisysocks noisysocks commented Jul 18, 2025 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1210735402872670?focus=true

Description

Screenshot 2025-07-18 at 11 43 53

Adds a Hide/Show Duck.ai button to the Customize drawer. It’s only shown when the Omnibar widget is shown.

To do this I added linkSettings to CustomizeContext which contains a data representation of additional links that will appear at the bottom of the Customize drawer. I personally think something like react-slot-fill would be a neater way to do this (and the Customize visibility toggles, too) but it’s too much effort for now.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@noisysocks noisysocks added the enhancement New feature or request label Jul 18, 2025
@noisysocks noisysocks requested review from shakyShane, mgurgel and a team as code owners July 18, 2025 01:50
@netlify Netlify
Copy link

netlify bot commented Jul 18, 2025 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 754daad
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6879a85ef37f4000085b0c0b
😎 Deploy Preview https://deploy-preview-1832--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions GitHub Actions
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

[Beta] Generated file diff

Time updated: Fri, 18 Jul 2025 01:51:18 GMT

Integration 
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js
  • integration/pages/new-tab/locales/en/new-tab.json

File has changed

Windows 
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js
  • windows/pages/new-tab/locales/en/new-tab.json

File has changed

Apple 
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js
  • dist/pages/new-tab/locales/en/new-tab.json

File has changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakyShane shakyShane Awaiting requested review from shakyShane shakyShane is a code owner

@mgurgel mgurgel Awaiting requested review from mgurgel mgurgel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@noisysocks