Skip to content

Incorrect yandex-music-track url parser #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Incorrect yandex-music-track url parser #48

wants to merge 1 commit into from

Conversation

DragorWW
Copy link

@DragorWW DragorWW commented Dec 1, 2020

remove regexp group for album id, because in real life we send only trackId, and don't use it.

@robonetphy
Copy link
Member

@neSpecc can you check this I am not familiar with Yandex

@robonetphy
Copy link
Member

Hi @DragorWW, Can you please update the same regex inside the test case inside service.js

@robonetphy robonetphy requested a review from neSpecc March 10, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc Awaiting requested review from neSpecc

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DragorWW @robonetphy