build: disallow non-maintainer changes to GitHub Actions workflows #48038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
approved these changes
Aug 11, 2025
dsanders11
requested changes
Aug 11, 2025
There was a problem hiding this comment.
no-dependency-change => disallowed-non-maintainer-change on line 29, since that's the identifier it uses to check for existing comments.
This might merge conflict with #48013 so we might want to land that first.
For completeness we probably want to change the job name, the name: value on L1, and the filename. I agree that "Disallowed Non-Maintainer Change" is a better more generic term than "Non-Maintainer Dependency Change".
93bec75 to
d4b788e
Compare
d4b788e to
9eade78
Compare
VerteDinde
approved these changes
Aug 12, 2025
dsanders11
approved these changes
Aug 12, 2025
There was a problem hiding this comment.
@codebytere, I merged #48013, so this just needs the merge conflict resolved but otherwise LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs #48024
We should also disallow non-maintainer changes to GitHub Actions files by default.
Checklist
npm testpassesRelease Notes
Notes: none