Skip to content

fix: webContent.fromId should be number instead of string #48059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: webContent.fromId should be number instead of string #48059

wants to merge 1 commit into from
+1 −1

Conversation

reitowo
Copy link
Member

@reitowo reitowo commented Aug 12, 2025

Description of Change

The fromId defined in the file accepts a string arg, while the api docs are number, the native binding also wants a int32.

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api-review/requested 🗳 new-pr 🌱 PR opened recently no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@reitowo