drm/nouveau/debugfs: Fix check of pm_runtime_get_sync failure

YueHaibing · Ben Skeggs · commit 909e9c9c4283 · 2019-03-22T09:57:58.000+10:00
pm_runtime_get_sync returns negative on failure. Fixes: eaeb901 ("drm/nouveau/debugfs: Wake up GPU before doing any reclocking") Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
@@ -181,7 +181,7 @@ nouveau_debugfs_pstate_set(struct file *file, const char __user *ubuf,
 	}
 
 	ret = pm_runtime_get_sync(drm->dev);
-	if (IS_ERR_VALUE(ret) && ret != -EACCES)
+	if (ret < 0 && ret != -EACCES)
 		return ret;
 	ret = nvif_mthd(ctrl, NVIF_CONTROL_PSTATE_USER, &args, sizeof(args));
 	pm_runtime_put_autosuspend(drm->dev);

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ nouveau_debugfs_pstate_set(struct file file, const char __user ubuf,`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`ret = pm_runtime_get_sync(drm->dev);`
`184`		`- if (IS_ERR_VALUE(ret) && ret != -EACCES)`
	`184`	`+ if (ret < 0 && ret != -EACCES)`
`185`	`185`	`return ret;`
`186`	`186`	`ret = nvif_mthd(ctrl, NVIF_CONTROL_PSTATE_USER, &args, sizeof(args));`
`187`	`187`	`pm_runtime_put_autosuspend(drm->dev);`