-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat(ledc): Improve timer management with frequency/resolution matching #11452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 12m 46s ⏱️ Results for commit d68a146. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small optimization
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Description of Change
This pull request introduces enhancements to the LEDC (LED Controller) functionality by adding helper functions for timer management, improving channel attachment logic, and extending the
ledc_channel_handle_t
structure. The changes aim to streamline timer allocation and deconfiguration, improve frequency and resolution matching, and provide better resource management.Tests scenarios
Tested using customized ledc example on C6 -> 4 LEDC Timers and checked on oscilloscope.
Related links
Closes #11373