Skip to content

feat(rmt): adds new function to send specific number of loops #11748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

feat(rmt): adds new function to send specific number of loops #11748

wants to merge 27 commits into from
+49 −15

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Aug 20, 2025 •
edited
Loading

Description of Change

Adds a new function rmtWriteLoopingCount() to send a specific number of times, repeating the same RMT Symbols.

Adds:
bool rmtWriteLoopingCount(int pin, rmt_data_t *data, size_t num_rmt_symbols, uint32_t loop_count)

It will send a pattern defined by *data RMT Symbols for loop_count times (repeated).
This is different from rmtWriteLooping(), which will repeat it for ever (endless looping).

Test Scenarios

To-Do:

  • add example
  • test it, specially when RMT channel is already sending something and it changes the loop mode/count.

Related links

Closes #11731

@SuGlider
feat(rmt): adds new function to send specific number of loops
3078091 
Adds a new function `rmtWriteLoopingCount()` to send a specific number of times, repeating the same RMT Symbols.
@SuGlider SuGlider added this to the 3.3.0 milestone Aug 20, 2025
@SuGlider SuGlider self-assigned this Aug 20, 2025
@SuGlider SuGlider requested a review from a team as a code owner August 20, 2025 14:25
@SuGlider SuGlider added the Area: Peripherals API Relates to peripheral's APIs. label Aug 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2025 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(rmt): adds new function to send specific number of loops":
    • body's lines must not be longer than 100 characters
  • the commit message "feat(rmt): rmtWriteLoopingCount improvement":
    • body's lines must not be longer than 100 characters
  • the commit message "rmt(fix): improve code readness":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "rmt(fix): improve code reliability":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello SuGlider, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against eedf368

@SuGlider
feat(rmt): adds new function to send specific number of loops
ddf778a 
Adds:
bool rmtWriteLoopingCount(int pin, rmt_data_t *data, size_t num_rmt_symbols, uint32_t loop_count)

It will send a pattern defined by `*data` RMT Symbols for `loop_count` times (repeated).

This is different from `rmtWriteLooping()`, which will repeat it for ever (endless looping).
@SuGlider SuGlider moved this from Todo to In Progress in Arduino ESP32 Core Project Roadmap Aug 20, 2025
@SuGlider SuGlider marked this pull request as draft August 20, 2025 14:37
SuGlider
SuGlider commented Aug 20, 2025
View reviewed changes
SuGlider
SuGlider commented Aug 20, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2025 •
edited
Loading

Test Results

 76 files   76 suites   13m 10s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit eedf368.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2025 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32P4000.000.00000.000.00
ESP32S30⚠️ +40.000.00000.000.00
ESP32S2💚 -400.000.00000.000.00
ESP32C30⚠️ +100.000.00000.000.00
ESP32C60⚠️ +100.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32💚 -1600.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ArduinoOTA/examples/BasicOTA000000000000--00
libraries/AsyncUDP/examples/AsyncUDPClient000000000000--00
libraries/AsyncUDP/examples/AsyncUDPMulticastServer000000000000--00
libraries/AsyncUDP/examples/AsyncUDPServer000000000000--00
libraries/BLE/examples/Beacon_Scanner00--00--00000000
libraries/BLE/examples/Client00--00--00000000
libraries/BLE/examples/Client_secure_static_passkey00--00--00000000
libraries/BLE/examples/EddystoneTLM_Beacon00--00--00000000
libraries/BLE/examples/EddystoneURL_Beacon00--00--00000000
libraries/BLE/examples/Notify00--00--00000000
libraries/BLE/examples/Scan00--00--00000000
libraries/BLE/examples/Server00--00--00000000
libraries/BLE/examples/Server_multiconnect00--00--00000000
libraries/BLE/examples/Server_secure_static_passkey00--00--00000000
libraries/BLE/examples/UART00--00--00000000
libraries/BLE/examples/Write00--00--00000000
libraries/BLE/examples/iBeacon00--00--00000000
libraries/DNSServer/examples/CaptivePortal000000000000--00
libraries/EEPROM/examples/eeprom_class0000000000000000
libraries/EEPROM/examples/eeprom_extra0000000000000000
libraries/EEPROM/examples/eeprom_write0000000000000000
libraries/ESP32/examples/AnalogOut/LEDCFade0000000000000000
libraries/ESP32/examples/AnalogOut/LEDCGammaFade0000------0000--
libraries/ESP32/examples/AnalogOut/LEDCSingleChannel0000000000000000
libraries/ESP32/examples/AnalogOut/LEDCSoftwareFade0000000000000000
libraries/ESP32/examples/AnalogOut/SigmaDelta0000000000000000
libraries/ESP32/examples/AnalogOut/ledcFrequency0000000000000000
libraries/ESP32/examples/AnalogOut/ledcWrite_RGB0000000000000000
libraries/ESP32/examples/AnalogRead0000000000000000
libraries/ESP32/examples/AnalogReadContinuous0000000000000000
libraries/ESP32/examples/ArduinoStackSize0000000000000000
libraries/ESP32/examples/CI/CIBoardsTest000000💚 -4000000000
libraries/ESP32/examples/ChipID/GetChipID0000000000000000
libraries/ESP32/examples/DeepSleep/TimerWakeUp000000000000--00
libraries/ESP32/examples/FreeRTOS/BasicMultiThreading000000💚 -4000000000
libraries/ESP32/examples/FreeRTOS/Mutex0000000000000000
libraries/ESP32/examples/FreeRTOS/Queue0000000000000000
libraries/ESP32/examples/FreeRTOS/Semaphore0000000000000000
libraries/ESP32/examples/GPIO/BlinkRGB000000💚 -4000000000
libraries/ESP32/examples/GPIO/FunctionalInterrupt0000000000000000
libraries/ESP32/examples/GPIO/FunctionalInterruptLambda000000💚 -4000⚠️ +1000000
libraries/ESP32/examples/GPIO/FunctionalInterruptStruct0000000000000000
libraries/ESP32/examples/GPIO/GPIOInterrupt0000000000000000
libraries/ESP32/examples/HWCDC_Events000000--000000--
libraries/ESP32/examples/MacAddress/GetMacAddress0000000000000000
libraries/ESP32/examples/RMT/Legacy_RMT_Driver_Compatible0000000000000000
libraries/ESP32/examples/RMT/RMTCallback000000💚 -40000000💚 -40
libraries/ESP32/examples/RMT/RMTLoopback000000💚 -40000000💚 -40
libraries/ESP32/examples/RMT/RMTReadXJT000000💚 -40000000💚 -40
libraries/ESP32/examples/RMT/RMTWrite_RGB_LED000000💚 -40000000💚 -40
libraries/ESP32/examples/RMT/RMT_CPUFreq_Test000000💚 -40000000💚 -40
libraries/ESP32/examples/RMT/RMT_EndOfTransmissionState000000💚 -40000000💚 -40
libraries/ESP32/examples/RMT/RMT_LED_Blink000000💚 -40000000💚 -40
libraries/ESP32/examples/ResetReason/ResetReason0000000000000000
libraries/ESP32/examples/ResetReason/ResetReason20000000000000000
libraries/ESP32/examples/Serial/BaudRateDetect_Demo0000000000000000
libraries/ESP32/examples/Serial/OnReceiveError_BREAK_Demo0000000000000000
libraries/ESP32/examples/Serial/OnReceive_Demo0000000000000000
libraries/ESP32/examples/Serial/RS485_Echo_Demo0000000000000000
libraries/ESP32/examples/Serial/RxFIFOFull_Demo0000000000000000
libraries/ESP32/examples/Serial/RxTimeout_Demo0000000000000000
libraries/ESP32/examples/Serial/Serial_All_CPU_Freqs0000000000000000
libraries/ESP32/examples/Serial/Serial_STD_Func_OnReceive0000000000000000
libraries/ESP32/examples/Serial/onReceiveExample0000000000000000
libraries/ESP32/examples/Template/ExampleTemplate0000000000000000
libraries/ESP32/examples/Time/SimpleTime000000000000--00
libraries/ESP32/examples/Timer/RepeatTimer0000000000000000
libraries/ESP32/examples/Timer/WatchdogTimer0000000000000000
libraries/ESP_I2S/examples/ES8388_loopback000000💚 -4000000000
libraries/ESP_I2S/examples/Simple_tone0000000000000000
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Master00--00000000--00
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Slave00--00000000--00
libraries/ESP_NOW/examples/ESP_NOW_Network00--00000000--00
libraries/ESP_NOW/examples/ESP_NOW_Serial00--00000000--00
libraries/ESPmDNS/examples/mDNS-SD_Extended000000000000--00
libraries/ESPmDNS/examples/mDNS_Web_Server000000000000--00
libraries/Ethernet/examples/ETH_W5500_Arduino_SPI000000💚 -4000000000
libraries/Ethernet/examples/ETH_W5500_IDF_SPI000000💚 -4000000000
libraries/Ethernet/examples/ETH_WIFI_BRIDGE000000💚 -400000--00
libraries/FFat/examples/FFat_Test0000000000000000
libraries/FFat/examples/FFat_time000000000000--00
libraries/HTTPClient/examples/Authorization000000000000--00
libraries/HTTPClient/examples/BasicHttpClient000000000000--00
libraries/HTTPClient/examples/BasicHttpsClient000000000000--00
libraries/HTTPClient/examples/HTTPClientEnterprise00--00000000--00
libraries/HTTPClient/examples/ReuseConnection000000000000--00
libraries/HTTPClient/examples/StreamHttpClient000000000000--00
libraries/HTTPUpdate/examples/httpUpdate000000000000--00
libraries/HTTPUpdate/examples/httpUpdateSPIFFS000000💚 -400000--00
libraries/HTTPUpdate/examples/httpUpdateSecure000000💚 -400000--00
libraries/HTTPUpdateServer/examples/WebUpdater000000💚 -400000--00
libraries/Hash/examples/HEX0000000000000000
libraries/Hash/examples/MD50000000000000000
libraries/Hash/examples/PBKDF2_HMAC0000000000000000
libraries/Hash/examples/SHA10000000000000000
libraries/Hash/examples/SHA20000000000000000
libraries/Hash/examples/SHA30000000000000000
libraries/Hash/examples/SHA3Stream0000000000000000
libraries/Insights/examples/DiagnosticsSmokeTest00--00000000--00
libraries/Insights/examples/MinimalDiagnostics00--00000000--00
libraries/LittleFS/examples/LITTLEFS_test0000000000000000
libraries/LittleFS/examples/LITTLEFS_time000000000000--00
libraries/Matter/examples/MatterColorLight00--00💚 -4000000000
libraries/Matter/examples/MatterCommissionTest00--000000000000
libraries/Matter/examples/MatterComposedLights00--000000000000
libraries/Matter/examples/MatterContactSensor00--00💚 -4000000000
libraries/Matter/examples/MatterDimmableLight00--00💚 -4000000000
libraries/Matter/examples/MatterEnhancedColorLight00--00💚 -4000000000
libraries/Matter/examples/MatterEvents00--000000000000
libraries/Matter/examples/MatterFan00--00💚 -4000000000
libraries/Matter/examples/MatterHumiditySensor00--000000000000
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs00--000000000000
libraries/Matter/examples/MatterMinimum00--00💚 -40⚠️ +100000000
libraries/Matter/examples/MatterOccupancySensor00--000000000000
libraries/Matter/examples/MatterOnIdentify00--00💚 -40⚠️ +100000000
libraries/Matter/examples/MatterOnOffLight00--00💚 -4000000000
libraries/Matter/examples/MatterOnOffPlugin00--00💚 -4000000000
libraries/Matter/examples/MatterPressureSensor00--000000000000
libraries/Matter/examples/MatterSmartButon00--000000000000
libraries/Matter/examples/MatterTemperatureLight00--00💚 -4000000000
libraries/Matter/examples/MatterTemperatureSensor00--000000000000
libraries/Matter/examples/MatterThermostat00--000000000000
libraries/NetBIOS/examples/ESP_NBNST000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientInsecure000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientPSK000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientSecure000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientSecureEnterprise00--00000000--00
libraries/NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientShowPeerCredentials000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientTrustOnFirstUse000000000000--00
libraries/OpenThread/examples/CLI/COAP/coap_lamp00--------0000--
libraries/OpenThread/examples/CLI/COAP/coap_switch00--------0000--
libraries/OpenThread/examples/CLI/SimpleCLI00--------0000--
libraries/OpenThread/examples/CLI/SimpleNode00--------0000--
libraries/OpenThread/examples/CLI/SimpleThreadNetwork/ExtendedRouterNode00--------0000--
libraries/OpenThread/examples/CLI/SimpleThreadNetwork/LeaderNode00--------0000--
libraries/OpenThread/examples/CLI/SimpleThreadNetwork/RouterNode00--------0000--
libraries/OpenThread/examples/CLI/ThreadScan00--------0000--
libraries/OpenThread/examples/CLI/onReceive00--------0000--
libraries/OpenThread/examples/Native/SimpleThreadNetwork/LeaderNode00--------0000--
libraries/OpenThread/examples/Native/SimpleThreadNetwork/RouterNode00--------0000--
libraries/PPP/examples/PPP_Basic000000💚 -4000000000
libraries/PPP/examples/PPP_WIFI_BRIDGE000000💚 -400000--00
libraries/Preferences/examples/Prefs2Struct0000000000000000
libraries/Preferences/examples/StartCounter0000000000000000
libraries/RainMaker/examples/RMakerCustom00--00💚 -400000----
libraries/RainMaker/examples/RMakerCustomAirCooler00--⚠️ +40000000----
libraries/RainMaker/examples/RMakerSonoffDualR300--00💚 -400000----
libraries/RainMaker/examples/RMakerSwitch00--00💚 -400000----
libraries/SD/examples/SD_Test000000💚 -4000000000
libraries/SD/examples/SD_time000000💚 -400000--00
libraries/SPI/examples/SPI_Multiple_Buses000000💚 -4000000000
libraries/SPIFFS/examples/SPIFFS_Test0000000000000000
libraries/SPIFFS/examples/SPIFFS_time000000000000--00
libraries/TFLiteMicro/examples/hello_world0000000000000000
libraries/Ticker/examples/Blinker000000💚 -4000000000
libraries/Ticker/examples/TickerBasic000000💚 -4000000000
libraries/Ticker/examples/TickerParameter000000💚 -4000000000
libraries/Update/examples/AWS_S3_OTA_Update000000💚 -400000--00
libraries/Update/examples/HTTPS_OTA_Update000000000000--00
libraries/Update/examples/HTTP_Client_AES_OTA_Update000000💚 -400000--00
libraries/Update/examples/HTTP_Server_AES_OTA_Update000000💚 -400000--00
libraries/Update/examples/OTAWebUpdater000000💚 -400000--00
libraries/Update/examples/SD_Update000000💚 -4000000000
libraries/WebServer/examples/AdvancedWebServer000000💚 -400000--00
libraries/WebServer/examples/FSBrowser000000000000--00
libraries/WebServer/examples/Filters000000💚 -400000--00
libraries/WebServer/examples/HelloServer000000💚 -400000--00
libraries/WebServer/examples/HttpAdvancedAuth000000💚 -400000--00
libraries/WebServer/examples/HttpAuthCallback000000💚 -400000--00
libraries/WebServer/examples/HttpAuthCallbackInline000000💚 -400000--00
libraries/WebServer/examples/HttpBasicAuth000000💚 -400000--00
libraries/WebServer/examples/HttpBasicAuthSHA1000000💚 -400000--00
libraries/WebServer/examples/HttpBasicAuthSHA1orBearerToken000000💚 -400000--00
libraries/WebServer/examples/Middleware00--00000000--00
libraries/WebServer/examples/MultiHomedServers0000⚠️ +40💚 -400000--00
libraries/WebServer/examples/PathArgServer000000000000--00
libraries/WebServer/examples/SDWebServer000000💚 -400000--00
libraries/WebServer/examples/SimpleAuthentification000000000000--00
libraries/WebServer/examples/UploadHugeFile000000💚 -400000--00
libraries/WebServer/examples/WebServer000000000000--00
libraries/WebServer/examples/WebUpdate000000💚 -400000--00
libraries/WiFi/examples/FTM/FTM_Initiator000000000000--00
libraries/WiFi/examples/FTM/FTM_Responder000000000000--00
libraries/WiFi/examples/SimpleWiFiServer000000💚 -400000--00
libraries/WiFi/examples/WPS00--00000000--00
libraries/WiFi/examples/WiFiAccessPoint000000💚 -400000--00
libraries/WiFi/examples/WiFiBlueToothSwitch00--00--0000--00
libraries/WiFi/examples/WiFiClient000000000000--00
libraries/WiFi/examples/WiFiClientBasic000000000000--00
libraries/WiFi/examples/WiFiClientConnect000000000000--00
libraries/WiFi/examples/WiFiClientEnterprise00--00000000--00
libraries/WiFi/examples/WiFiClientEvents000000000000--00
libraries/WiFi/examples/WiFiClientStaticIP000000000000--00
libraries/WiFi/examples/WiFiExtender000000000000--00
libraries/WiFi/examples/WiFiIPv6000000000000--00
libraries/WiFi/examples/WiFiMulti000000000000--00
libraries/WiFi/examples/WiFiMultiAdvanced000000000000--00
libraries/WiFi/examples/WiFiScan000000000000--00
libraries/WiFi/examples/WiFiScanAsync000000000000--00
libraries/WiFi/examples/WiFiScanDualAntenna000000000000--00
libraries/WiFi/examples/WiFiScanTime000000000000--00
libraries/WiFi/examples/WiFiSmartConfig00--00000000--00
libraries/WiFi/examples/WiFiTelnetToSerial000000000000--00
libraries/WiFi/examples/WiFiUDPClient000000000000--00
libraries/WiFiProv/examples/WiFiProv00--00000000--00
libraries/Wire/examples/WireMaster0000000000000000
libraries/Wire/examples/WireScan0000000000000000
libraries/Wire/examples/WireSlave0000000000000000
libraries/Wire/examples/WireSlaveFunctionalCallback0000000000000000
libraries/Zigbee/examples/Zigbee_Analog_Input_Output00--000000000000
libraries/Zigbee/examples/Zigbee_Binary_Input_Output00--------0000--
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light00--------0000--
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch00--000000000000
libraries/Zigbee/examples/Zigbee_Contact_Switch00--------0000--
libraries/Zigbee/examples/Zigbee_Dimmable_Light00--------0000--
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor00--000000000000
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor_MultiPhase00--000000000000
libraries/Zigbee/examples/Zigbee_Electrical_DC_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Fan_Control00--00💚 -4000000000
libraries/Zigbee/examples/Zigbee_Gateway00--000000----00
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Multistate_Input_Output00--000000000000
libraries/Zigbee/examples/Zigbee_OTA_Client00--------0000--
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_On_Off_Light00--------0000--
libraries/Zigbee/examples/Zigbee_On_Off_MultiSwitch00--000000000000
libraries/Zigbee/examples/Zigbee_On_Off_Switch00--000000000000
libraries/Zigbee/examples/Zigbee_PM25_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Power_Outlet00--00💚 -4000000000
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Range_Extender00--00💚 -4000000000
libraries/Zigbee/examples/Zigbee_Scan_Networks00--------0000--
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy00--------0000--
libraries/Zigbee/examples/Zigbee_Temperature_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Thermostat00--000000000000
libraries/Zigbee/examples/Zigbee_Vibration_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Window_Covering00--------0000--
libraries/ESP32/examples/DeepSleep/TouchWakeUp--000000------00
libraries/ESP32/examples/TWAI/TWAIreceive--00000000000000
libraries/ESP32/examples/TWAI/TWAItransmit--00000000000000
libraries/ESP32/examples/Touch/TouchButton--000000------00
libraries/ESP32/examples/Touch/TouchInterrupt--000000------00
libraries/ESP32/examples/Touch/TouchRead--000000------00
libraries/ESP_I2S/examples/Record_to_WAV--0000--------00
libraries/ESP_SR/examples/Basic--0000----------
libraries/Ethernet/examples/ETH_TLK110--00----------00
libraries/SD_MMC/examples/SD2USBMSC--0000----------
libraries/SD_MMC/examples/SDMMC_Test--0000--------00
libraries/SD_MMC/examples/SDMMC_time--0000--------00
libraries/USB/examples/CompositeDevice--000000--------
libraries/USB/examples/ConsumerControl--000000--------
libraries/USB/examples/CustomHIDDevice--000000--------
libraries/USB/examples/FirmwareMSC--000000--------
libraries/USB/examples/Gamepad--000000--------
libraries/USB/examples/HIDVendor--000000--------
libraries/USB/examples/Keyboard/KeyboardLogout--000000--------
libraries/USB/examples/Keyboard/KeyboardMessage--000000--------
libraries/USB/examples/Keyboard/KeyboardReprogram--000000--------
libraries/USB/examples/Keyboard/KeyboardSerial--000000--------
libraries/USB/examples/KeyboardAndMouseControl--000000--------
libraries/USB/examples/MIDI/MidiController--000000--------
libraries/USB/examples/MIDI/MidiInterface--000000--------
libraries/USB/examples/MIDI/MidiMusicBox--000000--------
libraries/USB/examples/MIDI/ReceiveMidi--000000--------
libraries/USB/examples/Mouse/ButtonMouseControl--000000--------
libraries/USB/examples/SystemControl--000000--------
libraries/USB/examples/USBMSC--000000--------
libraries/USB/examples/USBSerial--000000--------
libraries/USB/examples/USBVendor--000000--------
libraries/ESP32/examples/Camera/CameraWebServer----0000------00
ESP32/examples/Camera/CameraWebServer (2)----0000------💚 -160
ESP32/examples/Camera/CameraWebServer (3)----00----------
libraries/ESP32/examples/DeepSleep/ExternalWakeUp----0000------00
libraries/BluetoothSerial/examples/DiscoverConnect--------------00
libraries/BluetoothSerial/examples/GetLocalMAC--------------00
libraries/BluetoothSerial/examples/SerialToSerialBT--------------00
libraries/BluetoothSerial/examples/SerialToSerialBTM--------------00
libraries/BluetoothSerial/examples/SerialToSerialBT_Legacy--------------00
libraries/BluetoothSerial/examples/SerialToSerialBT_SSP--------------00
libraries/BluetoothSerial/examples/bt_classic_device_discovery--------------00
libraries/BluetoothSerial/examples/bt_remove_paired_devices--------------00
libraries/ESP32/examples/DeepSleep/SmoothBlink_ULP_Code--------------00
libraries/Ethernet/examples/ETH_LAN8720--------------00
libraries/SimpleBLE/examples/SimpleBleDevice--------------00

@SuGlider SuGlider requested a review from Copilot September 5, 2025 16:43
Copilot

This comment was marked as outdated.

Sign in to view

SuGlider and others added 2 commits September 5, 2025 15:35
@SuGlider @Copilot
feat(rmt): check the loop count parameter
f5d0513 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider @Copilot
feat(rmt): improve commentaries
e9aa349 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider SuGlider requested a review from Copilot September 5, 2025 18:38
Copilot

This comment was marked as outdated.

Sign in to view

SuGlider
SuGlider commented Sep 5, 2025
View reviewed changes
@SuGlider SuGlider requested a review from Copilot September 5, 2025 18:45
Copilot

This comment was marked as outdated.

Sign in to view

@SuGlider SuGlider requested a review from Copilot September 5, 2025 19:28
@SuGlider SuGlider requested a review from Copilot September 5, 2025 20:13
Copilot

This comment was marked as outdated.

Sign in to view

@SuGlider
feat(rmt): rmtWriteLoopingCount improvement
00989d4 
Updated rmtWriteLoopingCount to handle loop_count validation and added logic for single transmission.
@SuGlider
feat(rmt): improve verbose logging code
3bb70e7
@SuGlider SuGlider requested a review from Copilot September 5, 2025 20:37
Copilot

This comment was marked as outdated.

Sign in to view

SuGlider and others added 2 commits September 5, 2025 17:39
@SuGlider @Copilot
fix(rmt): code identation
f2218ba 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider @Copilot
fix(rmt): bad copy & paste of function signature
55b8244 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider SuGlider requested a review from Copilot September 5, 2025 20:40
Copilot

This comment was marked as outdated.

Sign in to view

@SuGlider SuGlider requested a review from Copilot September 5, 2025 20:49
Copilot

This comment was marked as outdated.

Sign in to view

SuGlider and others added 2 commits September 5, 2025 17:51
@SuGlider @Copilot
rmt(fix): improve code reliability
a198804 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider
feat(rmt): improved code readness
8883c30
@SuGlider SuGlider requested a review from Copilot September 5, 2025 22:44
Copilot

This comment was marked as outdated.

Sign in to view

SuGlider and others added 2 commits September 5, 2025 19:48
@SuGlider @Copilot
fix(rmt): typo in commentary
c9c00f8 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider
fix(rmt): increase buffer size for loop count loop log msg
d4b31b2
@SuGlider SuGlider requested a review from Copilot September 5, 2025 22:51
Copilot

This comment was marked as outdated.

Sign in to view

SuGlider and others added 2 commits September 5, 2025 19:54
@SuGlider @Copilot
fix(rmt): typo in commentary
c5993be 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider @Copilot
fix(rmt): typo in commentary
a92d64f 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider SuGlider requested a review from Copilot September 5, 2025 22:54
Copilot

This comment was marked as outdated.

Sign in to view

SuGlider and others added 2 commits September 5, 2025 19:56
@SuGlider @Copilot
fix(rmt): buffer size for log message
9915feb 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider @Copilot
rmt(fix): improve code readness
eedf368 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider SuGlider requested a review from Copilot September 5, 2025 22:57
Copilot
Copilot AI reviewed Sep 5, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new RMT function to send patterns a specific number of times rather than infinitely. The PR introduces rmtWriteRepeated() which transmits RMT symbols for a fixed loop count, complementing the existing rmtWriteLooping() function that loops indefinitely.

Key changes:

  • Modified internal _rmtWrite() function to handle loop counts instead of boolean looping flag
  • Added rmtWriteRepeated() function for finite repetition with input validation
  • Updated function documentation to clarify looping behavior differences

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
cores/esp32/esp32-hal-rmt.h Adds function declaration and updates documentation for new repeated transmission feature
cores/esp32/esp32-hal-rmt.c Implements the repeated transmission logic and refactors internal write function to use numeric loop counts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 0 approving reviews are required to merge this pull request.

Assignees

@SuGlider SuGlider

Labels
Area: Peripherals API Relates to peripheral's APIs.
Projects
Arduino ESP32 Core Project Roadmap
Status: In Progress
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Add rmtWriteLoopingCount function to set loop count
1 participant
@SuGlider