Skip to content

Conversation

michel-gawron
Copy link

Fixes #77 and #40

@SenikTony
Copy link

@madisvain ping

@ash-jc-allen
Copy link
Contributor

Does anyone know if any progress was ever made on getting this reviewed for being pulled in? I'm currently making updates to the Laravel wrapper for this (https://github.com/ash-jc-allen/laravel-exchange-rates) and think this bugfix might be helpful 😄

@michel-gawron
Copy link
Author

Hi @ash-jc-allen ! Unfortunately I'm not sure whether the author is still supporting this repo or not 😕

@ash-jc-allen
Copy link
Contributor

Hi @michel-gawron! Ahh that's a shame 😞 Do we know if there's any forks of this that are still supported? It'd be a shame to let such a useful service go to waste.

@michel-gawron
Copy link
Author

I don't think there is an active fork - or I haven't seen one. In order to use this API and avoid the EUR-EUR bug, I made a temporary fix on my client code (if EUR-EUR then exchange rate = 1). It's a bit dirty but it does the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EUR to EUR not working
3 participants