Rename service-worker.js to firebase-messaging-sw.js
#381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firebase Messaging Service workers must be named `firebase-messaging-sw.js`. The name of this file should reflect that requirement, since users can be misled by the incorrect name, and run into issues if they try to copy it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation says that "In order to receive the onMessage event, your app must define the Firebase messaging service worker in
firebase-messaging-sw.js" FCM docs, so the name of the file used for the snippet should reflect this, otherwise users may run into issues if they try to copy it.Default SW name: https://github.com/firebase/firebase-js-sdk/blob/main/packages/messaging/src/util/constants.ts#L18
cl/673852085 (internal)