Remove json parsing if content type is not application/json #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #963
This approach removes the attempt to parse json if the content type is not application/json. One one hand, this, in addition to allowing reqparse to be used with Werkzeug >= 2.1.0, matches the behavior of newer versions of Flask/Werkzeug.
On the other hand, this may introduce unexpected behavior if users pin an older version of Flask but update Flask-Restful, as they will no longer parse json when the content type is different. Backwards compatibility could be more easily maintained by handling the get_json() exception, but this seems like a less explicit solution.