Skip to content

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Aug 18, 2025

This updates the text input team's issue triage query to exclude issues that have the following labels:

  1. triaged-accessibility
  2. triaged-codelabs
  3. triaged-games
  4. triaged-infra
  5. triaged-news

Background

In last week's triage, we discussed removing the a: text input label from our issue triage query as this bubbled up issues that did not need triaging.

It turns out that this query should exclude triaged issues, since it excludes issues with labels like triaged-windows. However, the query was missing a few triage teams. Adding these triage team exclusions allow us to see all untriaged text input issues, regardless of which triage team they are assigned to. I think this balances noise with our ability to see all text input issues.

Let me know if you have any feedback on this approach!

@github-actions github-actions bot added the d: docs/ flutter/flutter/docs, for contributors label Aug 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the issue triage query for the text input team to exclude more triaged issues. My review points out that some labels mentioned in the description are missing from the updated query and provides a corrected version. This ensures the query accurately reflects the intended filtering logic.

@loic-sharma
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the issue triage query for the text input team to exclude several more triaged-* labels, which will help in surfacing untriaged issues more effectively. The change also consolidates the label exclusions into a single -label filter. My feedback focuses on improving the readability of the markdown file by suggesting a way to handle the very long URL, in line with the project's style guide.

@loic-sharma
Copy link
Member Author

Hm, on second thought, I'll close this PR.

The text input team missed July's issue triage test: #171486.

Currently, we try to look at all untriaged text input issues, even if they're assigned to a platform team. Instead of looking at team-text-input/fyi-text-input issues that don't have triaged-text-input, we look at a: text input/team-text-input/fyi-text-input issues that don't have any triaged-* labels.

Unfortunately, this approach is incompatible with issues that are co-owned by multiple teams.

I'll send a PR to switch our issue triage query to team-text-input/fyi-text-input issues that don't have triaged-text-input.

@loic-sharma
Copy link
Member Author

Replaced by: #173999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d: docs/ flutter/flutter/docs, for contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant