[ios][tools] do not print out bonjour key not found in non-verbose mode #174001
+221
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbb4ce2 to
ba88a2c
Compare
hellohuanlin
commented
Aug 19, 2025
| expect(pipe.readAsStringSync(), isNot(contains(plutilErrorMessage))); | ||
| expect(result.stderr, isNot(contains(plutilErrorMessage))); | ||
| if (verbose) { | ||
| expect(result.stdout, contains(plutilErrorMessage)); |
There was a problem hiding this comment.
Verified consistent behavior on macOS 26 and 15.6:
On macOS 26:
- if verbose, plutil logs to its stderr, and we redirect to stdout
- if non-verbose, plutil logs to its stderr, and we ignore it
On macOS 15.6
- if verbose, plutil logs to its stdout, and we simply log it to current process's stdout
- if non-verbose, plutil logs to its stdout and we ignore it.
vashworth
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries #173569 again
That PR was reverted, because I didn't know that
streamOutputwas the one used during non-verbose modeThe logging logic is a bit convoluted, see: #173887
So this PR simply changes the condition from
To
So that if we skipErrorLog (will be true for bonjour features), it doesn't call
streamOutput.List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
Fixes #172627
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.