Skip to content

Correctly annotate affected package #5990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cipherboy
Copy link

This vulnerability was incorrectly edited by GitHub staff without consulting the project and has now resulted in incorrect reports propagating downstream.

As noted in the original report, this affects the rotation endpoints on the server; it does not impact the client API package.

See also: GHSA-prpj-rchp-9j5h

This vulnerability was incorrectly edited by GitHub staff without
consulting the project and has now resulted in incorrect reports
propagating downstream.

As noted in the original report, this affects the rotation endpoints on
the server; it does not impact the client API package.

See also: GHSA-prpj-rchp-9j5h

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
@github-actions github-actions bot changed the base branch from main to cipherboy/advisory-improvement-5990 August 12, 2025 16:36
cipherboy added a commit to cipherboy/golang-vulndb that referenced this pull request Aug 12, 2025
This vulnerability was incorrectly edited by GitHub staff without
consulting the project. As noted in the original report, this affects
the rotation endpoints on the server: it does not impact the client API
package in any way.

This vulnerability was original to HashiCorp Vault thus the initial
affected version is 0 (present in all earlier OpenBao versions).

The server is not directly importable and should not be consumed by
third-parties except through a release.

See also: GHSA-prpj-rchp-9j5h
See also: github/advisory-database#5990

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy added a commit to cipherboy/golang-vulndb that referenced this pull request Aug 12, 2025
This vulnerability was incorrectly edited by GitHub staff without
consulting the project. As noted in the original report, this affects
the rotation endpoints on the server: it does not impact the client API
package in any way.

This vulnerability was original to HashiCorp Vault thus the initial
affected version is 0 (present in all earlier OpenBao versions).

The server is not directly importable and should not be consumed by
third-parties except through a release.

See also: GHSA-prpj-rchp-9j5h
See also: github/advisory-database#5990
Resolves: golang#3877

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy added a commit to cipherboy/golang-vulndb that referenced this pull request Aug 12, 2025
This vulnerability was incorrectly edited by GitHub staff without
consulting the project. As noted in the original report, this affects
the rotation endpoints on the server: it does not impact the client API
package in any way.

This vulnerability was original to HashiCorp Vault thus the initial
affected version is 0 (present in all earlier OpenBao versions).

The server is not directly importable and should not be consumed by
third-parties except through a release.

See also: GHSA-prpj-rchp-9j5h
See also: github/advisory-database#5990
Resolves: golang#3877

Signed-off-by: Alexander Scheel <ascheel@gitlab.com>
cipherboy added a commit to cipherboy/golang-vulndb that referenced this pull request Aug 12, 2025
This vulnerability was incorrectly edited by GitHub staff without
consulting the project. As noted in the original report, this affects
the rotation endpoints on the server: it does not impact the client API
package in any way.

This vulnerability was original to HashiCorp Vault thus the initial
affected version is 0 (present in all earlier OpenBao versions).

The server is not directly importable and should not be consumed by
third-parties except through a release.

See also: GHSA-prpj-rchp-9j5h
See also: github/advisory-database#5990
Resolves: golang#3877

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy added a commit to cipherboy/golang-vulndb that referenced this pull request Aug 12, 2025
This vulnerability was incorrectly edited by GitHub staff without
consulting the project. As noted in the original report, this affects
the rotation endpoints on the server: it does not impact the client API
package in any way.

This vulnerability was original to HashiCorp Vault thus the initial
affected version is 0 (present in all earlier OpenBao versions).

The server is not directly importable and should not be consumed by
third-parties except through a release.

See also: GHSA-prpj-rchp-9j5h
See also: github/advisory-database#5990
Resolves: golang#3877

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy added a commit to cipherboy/golang-vulndb that referenced this pull request Aug 12, 2025
This vulnerability was incorrectly edited by GitHub staff without
consulting the project. As noted in the original report, this affects
the rotation endpoints on the server: it does not impact the client API
package in any way.

This vulnerability was original to HashiCorp Vault thus the initial
affected version is 0 (present in all earlier OpenBao versions).

The server is not directly importable and should not be consumed by
third-parties except through a release.

See also: GHSA-prpj-rchp-9j5h
See also: github/advisory-database#5990
Resolves: golang#3877

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy added a commit to cipherboy/golang-vulndb that referenced this pull request Aug 12, 2025
This vulnerability was incorrectly edited by GitHub staff without
consulting the project. As noted in the original report, this affects
the rotation endpoints on the server: it does not impact the client API
package in any way.

This vulnerability was original to HashiCorp Vault thus the initial
affected version is 0 (present in all earlier OpenBao versions).

The server is not directly importable and should not be consumed by
third-parties except through a release.

See also: GHSA-prpj-rchp-9j5h
See also: github/advisory-database#5990
Fixes: golang#3877

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
@JonathanLEvans
Copy link

Hi @cipherboy,

Apologies for the error and thanks for the correction 🙇.

2.3.1 is not uploaded to the Go registry. In these cases, we include the fixed Go pseudo-version (0.0.0-20250625150133-fe75468822a2) as well.

@cipherboy
Copy link
Author

@JonathanLEvans OpenBao's server is not meant to be imported by other Go modules so it isn't typically published in that manner (currently it is blocked by the registry by using a v2 version tag on a v1 module). I think that's why we opted to do a non-Go ecosystem at first (Package openbao on the GHSA linked above), though I've since started using go package references instead.

The only real way to consume this module is through a release build of the server binary (such as from upstream or manually rebuilding it yourself).

Thoughts? Should I remove the Go github.com/openbao/openbao affects entirely and replace it with a custom ecosystem line? 🤔

@JonathanLEvans
Copy link

@cipherboy Your distribution method makes sense. However, there is nothing stopping users may use the Go packaging system to import openbao so we want a global advisory to tell them whether the version they are using is affected if they do. We would want a global advisory regardless what you put as the package name in your repo advisory.

@advisory-database advisory-database bot merged commit 1b20754 into github:cipherboy/advisory-improvement-5990 Aug 12, 2025
2 checks passed
@advisory-database
Copy link
Contributor

Hi @cipherboy! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants