Skip to content

[GHSA-859w-5945-r5v3] Vite's server.fs.deny bypassed with /. for files under project root #6018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: Ecg-creator/advisory-improvement-6018
Choose a base branch
from

Conversation

Ecg-creator
Copy link

Updates

  • CVSS v4
  • Severity

Comments

GitHub

@github
Copy link
Collaborator

github commented Aug 15, 2025

Hi there @sapphi-red! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 05:49
Copilot

This comment was marked as outdated.

@Ecg-creator Ecg-creator marked this pull request as draft August 15, 2025 05:50
@Ecg-creator Ecg-creator requested a review from Copilot August 15, 2025 05:50
@github-actions github-actions bot changed the base branch from main to Ecg-creator/advisory-improvement-6018 August 15, 2025 05:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the security advisory GHSA-859w-5945-r5v3 to remove CVSS v4 scoring and change severity classification from MODERATE to CRITICAL for a Vite vulnerability that allows bypassing server.fs.deny restrictions.

  • Removes CVSS v4 scoring information from the severity section
  • Updates severity classification from MODERATE to CRITICAL
  • Updates the modification timestamp

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"score": "CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:P/VC:H/VI:N/VA:N/SC:N/SI:N/SA:N"
}
],
"severity": [],
Copy link
Preview

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The severity array is being emptied while the severity classification is being changed to CRITICAL. This creates an inconsistency where the main severity field indicates CRITICAL but the detailed severity scoring is removed. Consider either maintaining the CVSS v4 scoring with updated values or providing justification for removing the quantitative scoring while escalating the qualitative severity.

Suggested change
"severity": [],
"severity": [
{
"type": "CVSS_V4",
"score": 9.8,
"vector": "CVSS:4.0/AV:N/AC:L/PR:N/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N"
}
],

Copilot uses AI. Check for mistakes.

Copy link

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain the reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants