Rust: Update RegexInjectionExtensions to use getCanonicalPath. #19735
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates the NewSink class in RegexInjectionExtensions.qll to leverage getCanonicalPath for matching regex instantiations, replacing the previous getResolvedCrateOrigin + getResolvedPath approach.
- Switch filtering to
getCanonicalPathon theAddressabletarget - Replace
CallExprCfgNode+PathExprwithCallExprBase+Addressable - Adjust argument extraction to use
getArg(0)and refine literal exclusion
Comments suppressed due to low confidence (3)
rust/ql/lib/codeql/rust/security/regex/RegexInjectionExtensions.qll:57
- [nitpick] Using getStaticTarget() may not capture macro-generated or dynamically-resolved targets; verify that all intended call sites are still covered with this change.
call.getStaticTarget() = a and
rust/ql/lib/codeql/rust/security/regex/RegexInjectionExtensions.qll:53
- Consider adding or updating unit tests for NewSink to validate matching behavior with getCanonicalPath and prevent regressions.
private class NewSink extends Sink {
rust/ql/lib/codeql/rust/security/regex/RegexInjectionExtensions.qll:56
- [nitpick] Switching from CallExprCfgNode to CallExprBase broadens matching to non-CFG call expressions; if the sink is intended for CFG nodes only, consider using CallExprCfgNode to maintain the original scope.
exists(CallExprBase call, Addressable a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
RegexInjectionExtensions.qllto usegetCanonicalPathrather thangetResolvedPath+getResolvedCrateOrigin.@hvitved please confirm that this is the right direction we want to move in.