Set CWE-134 from 9.3 to 7.3 CVSS score for memory safe languages (#2) #19738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sync up to score given to javascript/ruby
There was a problem hiding this comment.
Pull Request Overview
This PR lowers the @security-severity for CWE-134 (uncontrolled/tainted format string) queries from 9.3 to 7.3 in memory-safe languages and adds corresponding change notes.
- Updated
@security-severityfrom 9.3 to 7.3 in Swift, Java, and C# QL queries. - Added change-note markdown files documenting the severity adjustment.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| swift/ql/src/queries/Security/CWE-134/UncontrolledFormatString.ql | Updated @security-severity from 9.3 to 7.3 |
| swift/ql/src/change-notes/2025-06-06-reduce-CWE-134-for-memory-safe-languages.md | Added change note for Swift severity adjustment |
| java/ql/src/Security/CWE/CWE-134/ExternallyControlledFormatString.ql | Updated @security-severity from 9.3 to 7.3 |
| java/ql/src/change-notes/2025-06-06-reduce-CWE-134-for-memory-safe-languages.md | Added change note for Java severity adjustment |
| csharp/ql/src/Security Features/CWE-134/UncontrolledFormatString.ql | Updated @security-severity from 9.3 to 7.3 |
| csharp/ql/src/change-notes/2025-06-06-reduce-CWE-134-for-memory-safe-languages.md | Added change note for C# severity adjustment |
Comments suppressed due to low confidence (2)
csharp/ql/src/Security Features/CWE-134/UncontrolledFormatString.ql:1
- The directory name 'Security Features' is inconsistent with other languages’ 'Security/CWE-134' structure; consider renaming to maintain consistency across the codebase.
csharp/ql/src/Security Features/CWE-134/UncontrolledFormatString.ql
java/ql/src/change-notes/2025-06-06-reduce-CWE-134-for-memory-safe-languages.md:4
- Ensure that any existing QL tests or validation suites that assert on the previous @security-severity value are updated to expect the new severity of 7.3, to avoid test failures or untested behavior.
* Adjusts the `@security-severity` from 9.3 to 7.3 for `java/tainted-format-string` to align `CWE-134` severity for memory safe languages to better reflect their impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of #19530, hopefully with line endings fixed so that CI will pass.