Rust: Rework type inference for method calls #20282

hvitved · 2025-08-25T19:50:46Z

No description provided.

github-advanced-security

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

rust/ql/lib/codeql/rust/internal/TypeInference.qll

shared/typeinference/codeql/typeinference/internal/TypeInference.qll

rust/ql/lib/codeql/rust/internal/TypeInference.qll

shared/typeinference/codeql/typeinference/internal/TypeInference.qll


      /**
       * Holds if `constraint` might occur as the third argument of
       * `potentialInstantiationOf`. Defaults to simply projecting the third
       * argument of `potentialInstantiationOf`.
       */
-      default predicate relevantTypeMention(TypeMention tm) { potentialInstantiationOf(_, _, tm) }
+      default predicate relevantTypeMention(Constraint tm) { potentialInstantiationOf(_, _, tm) }


rust/ql/lib/codeql/rust/internal/TypeInference.qll

+pragma[nomagic]
+private Type inferMethodCallExprType(AstNode n, TypePath path) {
+  exists(
+    MethodCallMatchingInput::Access a, MethodCallMatchingInput::AccessPosition apos, string state,


rust/ql/lib/codeql/rust/internal/TypeInference.qll

+        |
+          functionResolutionDependsOnArgument(impl, _, result, pos, _, _)
+          or
+          exists(TypeParameter tp | traitTypeParameterOccurrence(trait, resolved, _, pos, _, tp) |


rust/ql/lib/codeql/rust/internal/TypeInference.qll

+ * `self5` | `impl T2 for X` | `X`
+ */
+private class FunctionPositionType extends TFunctionPositionType {
+  private predicate asFunctionPositionType(Function f, FunctionPosition pos, ImplOrTraitItemNode i) {


rust/ql/lib/codeql/rust/internal/TypeInference.qll


-    pragma[nomagic]
-    abstract Type getParameterType(DeclarationPosition dpos, TypePath path);
+  private predicate asInheritedFunctionPositionType(


rust/ql/lib/codeql/rust/internal/TypeInference.qll

Copilot

Pull Request Overview

This PR reworks type inference for method calls in the Rust codeQL extractor, addressing a major limitation where method calls with multiple potential targets couldn't be properly resolved. The changes implement a more sophisticated approach that distinguishes between stateful and stateless contexts to improve method resolution accuracy.

Key changes:

Introduced stateful type inference to handle method calls with multiple candidates
Updated type inference infrastructure to support state-based resolution
Enhanced method call target resolution for complex scenarios

Reviewed Changes

Copilot reviewed 34 out of 36 changed files in this pull request and generated 2 comments.

File	Description
`shared/typeinference/codeql/typeinference/internal/TypeInference.qll`	Major refactoring to support stateful type inference, introducing `MatchingWithState` module and state-based method resolution
`rust/ql/lib/codeql/rust/internal/TypeMention.qll`	Added new type mention classes including `SelfParameterImplicitMention` for handling implicit `self` parameters
`rust/ql/lib/codeql/rust/internal/Type.qll`	Added support for union types, never type, and pointer types, enhancing the type system coverage
Multiple `.expected` files	Updated test expectations reflecting improved method call resolution accuracy

Copilot · 2025-09-03T17:53:50Z

rust/ql/lib/codeql/rust/internal/PathResolution.qll

      filepath.matches("%/main.rs") and
-      startline = 52
+      startline = 167


This hardcoded line number (167) in the debug module appears to be a leftover from development/testing. Consider removing this specific line constraint or making it configurable to avoid issues when the test file structure changes.

See below for a potential fix:

filepath.matches("%/main.rs")

shared/typeinference/codeql/typeinference/internal/TypeInference.qll

          }

          /** Holds if this relevant access should satisfy `constraint`. */
-          Type getConstraint() { relevantAccessConstraint(a, target, apos, path, result) }
+          Type getConstraint(Declaration target) {


rust/ql/lib/codeql/rust/internal/TypeInference.qll

Copilot

Pull Request Overview

This PR reworks type inference for method calls in Rust by enhancing the type inference framework to support more complex scenarios. The changes improve method resolution by introducing state-based matching and by correcting type parameter handling.

Key changes:

Introduction of a state-based type matching system (MatchingWithState) that can track additional context during method resolution
Correction of type parameter constraints and constraint satisfaction logic
Extension of type system to support additional Rust types and improve dereference handling

Reviewed Changes

Copilot reviewed 32 out of 34 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`shared/typeinference/codeql/typeinference/internal/TypeInference.qll`	Major refactoring introducing `MatchingWithState` module and correcting type parameter constraint handling
`rust/ql/lib/codeql/rust/internal/TypeMention.qll`	Adds support for additional type mentions including union types, never types, and pointer types
`rust/ql/lib/codeql/rust/internal/Type.qll`	Extends type system with union, never, and pointer types
`rust/ql/lib/codeql/rust/internal/PathResolution.qll`	Adds trait visibility helpers and improves debugging support
`rust/ql/lib/codeql/rust/frameworks/stdlib/Stdlib.qll`	Adds modeling for `Deref` and `Index` traits
`rust/ql/lib/codeql/rust/elements/internal/UnionImpl.qll`	Implements field access for union types
`rust/ql/lib/codeql/rust/elements/internal/OperationImpl.qll`	Exposes operator overloading information
Multiple test files	Updated expected results reflecting improved type inference

Comments suppressed due to low confidence (1)

shared/typeinference/codeql/typeinference/internal/TypeInference.qll:1

The removed code appears to be checking for inconsistent type parameter instantiations by comparing different paths for the same type parameter. The removal of this logic could allow incorrect type matches to pass through. This should be verified as intentional or the logic should be restored with proper implementation.

/**

rust/ql/lib/codeql/rust/internal/TypeInference.qll

+    pragma[nomagic]
+    private Type getACandidateReceiverTypeAtNoBorrowNoMatch(TypePath path, string derefChain) {
+      result = this.getACandidateReceiverTypeAtNoBorrow(path, derefChain) and
+      exists(Type type, string name, int arity, string derefChainBorrow |


rust/ql/lib/codeql/rust/internal/TypeInference.qll

+    pragma[nomagic]
+    private Type getACandidateReceiverTypeAtNoBorrowNoMatch(TypePath path, string derefChain) {
+      result = this.getACandidateReceiverTypeAtNoBorrow(path, derefChain) and
+      exists(Type type, string name, int arity, string derefChainBorrow |


rust/ql/lib/codeql/rust/internal/TypeInference.qll

+    pragma[nomagic]
+    private Type getACandidateReceiverTypeAtNoMatch(TypePath path, string derefChain) {
+      result = this.getACandidateReceiverTypeAtNoBorrowNoMatch(path, derefChain) and
+      exists(Type type, string name, int arity, string derefChainBorrow |


rust/ql/lib/codeql/rust/internal/TypeInference.qll

+    pragma[nomagic]
+    private Type getACandidateReceiverTypeAtNoMatch(TypePath path, string derefChain) {
+      result = this.getACandidateReceiverTypeAtNoBorrowNoMatch(path, derefChain) and
+      exists(Type type, string name, int arity, string derefChainBorrow |


rust/ql/lib/codeql/rust/internal/TypeInference.qll

+    predicate potentialInstantiationOf(
+      MethodCallCand mcc, TypeAbstraction abs, FunctionPositionType constraint
+    ) {
+      exists(MethodCall mc, Type type, string name, int arity |


rust/ql/lib/codeql/rust/internal/TypeInference.qll

+    predicate potentialInstantiationOf(
+      MethodCallCand mcc, TypeAbstraction abs, FunctionPositionType constraint
+    ) {
+      exists(MethodCall mc, Type type, string name, int arity |


github-actions bot added the Rust Pull requests that update Rust code label Aug 25, 2025

github-advanced-security bot found potential problems Aug 25, 2025

View reviewed changes

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch 2 times, most recently from e4cfb86 to 4a8c37c Compare August 26, 2025 18:30

github-advanced-security bot found potential problems Aug 26, 2025

View reviewed changes

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from 4a8c37c to e75d79e Compare August 27, 2025 15:34

github-advanced-security bot found potential problems Aug 27, 2025

View reviewed changes

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch 8 times, most recently from 61866bf to 2d1ed65 Compare September 1, 2025 09:45

github-advanced-security bot found potential problems Sep 1, 2025

View reviewed changes

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from 2d1ed65 to 3d19a06 Compare September 1, 2025 10:30

github-advanced-security bot found potential problems Sep 1, 2025

View reviewed changes

rust/ql/lib/codeql/rust/internal/TypeInference.qll Fixed Show fixed Hide fixed

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from 3d19a06 to 153c10b Compare September 1, 2025 17:56

github-advanced-security bot found potential problems Sep 1, 2025

View reviewed changes

rust/ql/lib/codeql/rust/internal/TypeInference.qll Fixed Show fixed Hide fixed

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from 153c10b to e161d4c Compare September 1, 2025 18:35

github-advanced-security bot found potential problems Sep 1, 2025

View reviewed changes

rust/ql/lib/codeql/rust/internal/TypeInference.qll Fixed Show fixed Hide fixed

rust/ql/lib/codeql/rust/internal/TypeInference.qll Fixed Show fixed Hide fixed

rust/ql/lib/codeql/rust/internal/TypeInference.qll Fixed Show fixed Hide fixed

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from dd45f7b to a20c440 Compare September 2, 2025 07:24

github-advanced-security bot found potential problems Sep 2, 2025

View reviewed changes

rust/ql/lib/codeql/rust/internal/TypeInference.qll Fixed Show fixed Hide fixed

rust/ql/lib/codeql/rust/internal/TypeInference.qll Fixed Show fixed Hide fixed

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch 5 times, most recently from f45d2d5 to f9f8782 Compare September 3, 2025 13:07

github-advanced-security bot found potential problems Sep 3, 2025

View reviewed changes

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from f9f8782 to 4bfd7aa Compare September 3, 2025 15:00

github-advanced-security bot found potential problems Sep 3, 2025

View reviewed changes

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from 4bfd7aa to 8cd0e06 Compare September 3, 2025 15:17

github-advanced-security bot found potential problems Sep 3, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings September 3, 2025 17:52

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from eb173a1 to 39b1a4a Compare September 3, 2025 17:52

Copilot AI reviewed Sep 3, 2025

View reviewed changes

hvitved added 3 commits September 3, 2025 20:03

Shared: Make some generalizations in type inference library

642bfbd

Rust: Add type inference tests

fc9ce33

wip

195a708

This comment was marked as outdated.

Sign in to view

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from 39b1a4a to b4bd65b Compare September 3, 2025 18:43

github-advanced-security bot found potential problems Sep 3, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings September 3, 2025 19:00

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from b4bd65b to cb8a603 Compare September 3, 2025 19:00

This comment was marked as outdated.

Sign in to view

github-advanced-security bot found potential problems Sep 3, 2025

View reviewed changes

rust/ql/lib/codeql/rust/internal/TypeInference.qll Fixed Show fixed Hide fixed

hvitved mentioned this pull request Sep 4, 2025

Shared: Make some generalizations in type inference library #20358

Open

wip2

d11b22b

Copilot AI review requested due to automatic review settings September 4, 2025 05:56

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from 2748229 to fb5f768 Compare September 4, 2025 05:57

Copilot AI reviewed Sep 4, 2025

View reviewed changes

hvitved added 2 commits September 4, 2025 11:52

update expected

7662edf

wip

6f6437f

hvitved force-pushed the rust/type-inference-method-call-resolution-rework branch from fb5f768 to 6f6437f Compare September 4, 2025 11:00

github-advanced-security bot found potential problems Sep 4, 2025

View reviewed changes

Rust: Rework type inference for method calls #20282

Are you sure you want to change the base?

Rust: Rework type inference for method calls #20282

Conversation

hvitved commented Aug 25, 2025

Uh oh!

github-advanced-security bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Uh oh!

Uh oh!

Uh oh!

Check warning

Uh oh!

Check warning

Check warning

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Check warning

This comment was marked as outdated.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!