Ruby: Fix some Ql4Ql violations. #20332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several Ql4Ql violations related to code quality and consistency in the Ruby CodeQL library. The changes primarily address documentation improvements, variable scoping optimizations, and spelling corrections.
- Fixed parameter documentation references to use correct variable names
- Corrected spelling from "modelling" to "modeling" in API documentation
- Optimized variable scoping by moving declarations closer to their usage
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ruby/ql/lib/codeql/ruby/security/ImproperMemoizationQuery.qll | Updated parameter documentation to reference correct variable names |
| ruby/ql/lib/codeql/ruby/regexp/internal/ParseRegExp.qll | Fixed parameter name reference in documentation from snake_case to camelCase |
| ruby/ql/lib/codeql/ruby/frameworks/http_clients/NetHttp.qll | Moved connectionNode variable declaration into exists clause for better scoping |
| ruby/ql/lib/codeql/ruby/frameworks/http_clients/Excon.qll | Moved connectionNode variable declaration into exists clause and fixed parentheses |
| ruby/ql/lib/codeql/ruby/frameworks/core/Kernel.qll | Improved documentation to specify what the predicate holds for |
| ruby/ql/lib/codeql/ruby/ApiGraphs.qll | Corrected spelling from "modelling" to "modeling" |
aschackmull
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some Ql4Ql violations based on the following checks
ql/field-only-used-in-charpredql/could-be-castql/counting-to-zeroql/dataflow-module-naming-conventionql/if-with-noneql/missing-parameter-qldocql/misspellingDCA looks good.