Fix backslashes being accepted by sanitizeArtifactName
#2922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR tightens the sanitizeArtifactName regex to disallow backslashes and adds a corresponding test case to prevent debug upload errors.
- Removed backslash (
\) from allowed characters in the regex for artifact names. - Added a test case to verify backslashes are stripped out.
- Updated both TypeScript sources and compiled JavaScript outputs to keep them in sync.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/debug-artifacts.ts | Updated regex to disallow backslashes in names. |
| src/debug-artifacts.test.ts | Added test case for backslashes in names. |
| lib/debug-artifacts.js | Mirrored regex update in compiled output. |
| lib/debug-artifacts.test.js | Mirrored test addition in compiled tests. |
Comments suppressed due to low confidence (1)
src/debug-artifacts.test.ts:21
- Consider adding a test case to ensure valid characters like hyphens and underscores are preserved (e.g.,
foo-bar_baz→foo-bar_baz).
t.deepEqual(
aeisenberg
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifact names may not contain backslashes, but
sanitizeArtifactNameaccepts them, potentially resulting in errors during debug artifact uploads:This PR removes them from the list of acceptable characters in the regex and adds a test case.
Merge / deployment checklist