Prepare action for public rust support #2929
Merged
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Rust support logic to only enable the experimental CodeQL feature flag when the installed CodeQL version lacks built-in Rust support.
- Add a
codeql.resolveLanguages()check before exportingCODEQL_ENABLE_EXPERIMENTAL_FEATURESfor Rust - Mirror the updated logic and comment in both the TypeScript source and compiled JavaScript
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/init-action.ts | Conditionally set experimental Rust feature flag based on detected CodeQL support |
| lib/init-action.js | Apply the same conditional check and updated comment in the built JS |
esbena
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that once the
codeqlthat is being used by the action supports Rust extraction out of the box we skip all the experimental handling code.Functionally (considering the feature flag will also be switched at that moment), this will primarily result in skipping to print
Experimental rust analysis enabledin that case. Once the feature flag is switched, we can clean up this code (though not remove it entirely to ensure backward compatibility).Merge / deployment checklist