Skip to content

Only display cleanup-info log when relevant #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025

Conversation

henrymercer
Copy link
Contributor

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner August 15, 2025 16:25
@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 16:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the logging behavior by only displaying the deprecation warning for the cleanup-level input when the input is actually provided by users.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/analyze-action.ts Updates condition to check for truthy cleanup-level input instead of non-empty string
lib/analyze-action.js Generated JavaScript equivalent of the TypeScript changes

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@henrymercer henrymercer enabled auto-merge August 15, 2025 16:28
@henrymercer henrymercer merged commit 3966569 into main Aug 15, 2025
337 checks passed
@henrymercer henrymercer deleted the henrymercer/fix-cleanup-info branch August 15, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants