Remove unused C++ BMN FF #3039
Open
Remove unused C++ BMN FF #3039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused C++ Build Mode None (BMN) feature flag and its associated logic. The feature flag CODEQL_EXTRACTOR_CPP_BUILD_MODE_NONE is no longer needed since C++ BMN now works automatically when build-mode: none is configured.
Key Changes
- Removes confusing log message that would always appear when
c-cppwas configured, regardless of the actual build-mode value - Eliminates the unused
CppBuildModeNonefeature flag from the feature flags enum and configuration - Cleans up related initialization logic in the init-action module
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/init-action.ts | Removes the C++ BMN environment variable setup logic and logging |
| src/feature-flags.ts | Removes the CppBuildModeNone feature flag enum value and configuration |
| lib/init-action.js | Generated JavaScript equivalent of TypeScript changes |
| lib/feature-flags.js | Generated JavaScript equivalent of TypeScript changes |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
CODEQL_EXTRACTOR_CPP_BUILD_MODE_NONEno longer has any effect. C++ BMN will work wheneverbuild-mode: noneis configured for it.This PR removes a confusing log message that would result in
Setting C++ build-mode: none to falsegetting logged wheneverc-cppwas configured as language, regardless of what value was provided for thebuild-modeinput.Since the FF involved in the check isn't used elsewhere in the Action, this PR also removes it.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist