Skip to content

Clarify what gitignore templates are/do #39813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Aug 12, 2025

Why:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 12, 2025
Copy link
Contributor

github-actions bot commented Aug 12, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
repositories/creating-and-managing-repositories/creating-a-new-repository.md fpt
ghec
ghes@ 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.17 3.16 3.15 3.14

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@jsoref
Copy link
Contributor Author

jsoref commented Aug 12, 2025

@Sharra-writes I see CI is still quite unhappy. Are the Review links supposed to work? I guess that feature was removed in 95d7a2a? 😕

@Sharra-writes
Copy link
Contributor

Sharra-writes commented Aug 12, 2025

@jsoref Our engineers are working to figure out the CI problems. It's a doc specific problem, which had everyone stumped for a bit, since docs and docs-internal are synced. Even though I trust you to know what you're talking about, I should probably run your wording by the relevant engineering team anyway to see if they have nitpicks. Hopefully all the checks will be fixed by the time they get back to me. 🤞

Edit: Right, review links. I don't actually know, because I was still very much being trained when that was removed, and no one explained it to me. 😅

@jsoref
Copy link
Contributor Author

jsoref commented Aug 12, 2025

Oh, I only know what words mean. I can't claim to understand if the changes I'm making are desirable/agreeable to GitHub. Take your time.


microsoft/playwright#12487 (comment)

SyntaxError: The requested module '@playwright/test' does not provide an export named 'Page'
I'm using node v16.13.1 and playwright 1.20.1.

Oh I see, it's a type. I changed it to import { test, expect, type Page } from '@playwright/test'; and I'm back in business.

import { Page, test as Test } from '@playwright/test'

-import { Page, test as Test } from '@playwright/test' 
+import { type Page, test as Test } from '@playwright/test' 

I know enough not to bother making a PR for this stuff.

@Sharra-writes Sharra-writes added content This issue or pull request belongs to the Docs Content team repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Aug 12, 2025
@hstor12

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team repositories Content related to repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a new repository doesn't mention gitignore templates
3 participants