Skip to content

Update create-custom-protection-rules.md #39863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update create-custom-protection-rules.md #39863

wants to merge 2 commits into from
+3 −3

Conversation

MikeGBurns
Copy link

@MikeGBurns MikeGBurns commented Aug 15, 2025 •
edited
Loading

Additional details and corrections on approving or rejecting a deployment request.

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@MikeGBurns
Update create-custom-protection-rules.md
aad88a5 
Additional details and corrections on approving or rejecting a deployment request.
@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 15:21
@welcome Welcome
Copy link

welcome bot commented Aug 15, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copilot
Copilot AI reviewed Aug 15, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates documentation for custom protection rules in GitHub Actions deployments, specifically improving the instructions for approving or rejecting deployment requests. The changes provide additional technical details and correct formatting inconsistencies.

Key changes:

  • Corrects API endpoint casing in the access token URL
  • Enhances the deployment approval/rejection step with more comprehensive implementation details
  • Improves clarity on required parameters and expected responses

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 15, 2025 •
edited
Loading

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
actions/how-tos/deploy/configure-and-manage-deployments/create-custom-protection-rules.md fpt
ghec
ghes@ 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.17 3.16 3.15 3.14

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 15, 2025
@MikeGBurns @Copilot
Update content/actions/how-tos/deploy/configure-and-manage-deployment…
2f957b8 
…s/create-custom-protection-rules.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Sharra-writes
Copy link
Contributor

@MikeGBurns Thanks for opening a PR! I'll get this triaged for review.

@Sharra-writes Sharra-writes added content This issue or pull request belongs to the Docs Content team github_actions Pull requests that update GitHub Actions code and removed triage Do not begin working on this issue until triaged by the team labels Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeGBurns @Sharra-writes