Add context toolset and adjust readme #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the “context” toolset directly into the default group, removes the standalone initializer, updates server registration, and adjusts documentation to include new and reordered toolsets.
- Move context toolset creation into
DefaultToolsetGroupand dropInitContextToolset - Remove explicit context registration in the server and rely on group registration
- Update README with new toolsets (
context,code_security,notifications,secret_protection) and reorder entries
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/github/tools.go | Inlined context toolset into DefaultToolsetGroup and removed old init |
| pkg/github/search.go | Added a blank line after getClient call |
| internal/ghmcp/server.go | Removed InitContextToolset usage now handled by the toolset group |
| README.md | Added and reordered toolset entries in documentation table |
Comments suppressed due to low confidence (1)
README.md:150
- Reorder the table entries to match the initialization sequence in
DefaultToolsetGroupso users see the toolsets in the same order they’re registered.
| `context` | **Strongly recommended**: Tools that provide context about the current user and GitHub context you are operating in |
95489b2 to
1969f25
Compare
SamMorrowDrums
commented
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing toolsets to docs, and also makes the context tools a toolset in their own right - as the behaviour is a little strange that it sits outside the toolsets user controls.
As the namespaces concept appears to have more traction that toolsets, we will expand the concept to encompass resources for now, so that you can run multiple servers with different toolsets without a break in functionality.
This change partially aligns us with the namespaces spec proposal.
Closes: #482