Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit c9f8953

Browse files
author
Tyler Brandt
authored
chore: fix all lint warnings (optimizely#111)
- Use `npm run lint -- --fix` for most issues, and manually fix the rest
1 parent e9903d9 commit c9f8953

File tree

14 files changed

+94
-93
lines changed

14 files changed

+94
-93
lines changed

‎packages/optimizely-sdk/lib/core/decision_service/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ DecisionService.prototype.getVariation = function(experimentKey, userId, attribu
6868
if (!fns.isEmpty(attributes)) {
6969
if (attributes.hasOwnProperty(enums.CONTROL_ATTRIBUTES.BUCKETING_ID)) {
7070
bucketingId = attributes[enums.CONTROL_ATTRIBUTES.BUCKETING_ID];
71-
this.logger.log(LOG_LEVEL.DEBUG, sprintf('Setting the bucketing ID to %s.', bucketingId))
71+
this.logger.log(LOG_LEVEL.DEBUG, sprintf('Setting the bucketing ID to %s.', bucketingId));
7272
}
7373
}
7474

‎packages/optimizely-sdk/lib/core/decision_service/index.tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ describe('lib/core/decision_service', function() {
360360

361361
var testUserAttributes = {
362362
'browser_type': 'firefox',
363-
}
363+
};
364364
var userAttributesWithBucketingId = {
365365
'browser_type': 'firefox',
366366
'$opt_bucketing_id': '123456789'
@@ -436,7 +436,7 @@ describe('lib/core/decision_service', function() {
436436
var userProfileServiceInstance = {
437437
lookup: function () {
438438
},
439-
}
439+
};
440440
userProfileLookupStub = sinon.stub(userProfileServiceInstance, 'lookup');
441441
userProfileLookupStub.returns({
442442
user_id: 'test_user',

‎packages/optimizely-sdk/lib/core/event_builder/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ function getCommonEventParams(options) {
6666
key: attributeKey,
6767
type: CUSTOM_ATTRIBUTE_FEATURE_TYPE,
6868
value: attributes[attributeKey],
69-
});
69+
});
7070
}
7171
});
7272

@@ -77,7 +77,7 @@ function getCommonEventParams(options) {
7777
type: CUSTOM_ATTRIBUTE_FEATURE_TYPE,
7878
value: botFiltering,
7979
});
80-
};
80+
}
8181
return commonParams;
8282
}
8383

‎packages/optimizely-sdk/lib/core/event_builder/index.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ describe('lib/core/event_builder', function() {
290290

291291
assert.deepEqual(actualParams, expectedParams);
292292
});
293-
293+
294294
it('should fill in userFeatures for user agent and bot filtering (bot filtering enabled)', function() {
295295
var v4ConfigObj = projectConfig.createProjectConfig(testData.getTestProjectConfigWithFeatures());
296296
var expectedParams = {

‎packages/optimizely-sdk/lib/core/project_config/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ module.exports = {
141141
var hasReservedPrefix = attributeKey.indexOf(RESERVED_ATTRIBUTE_PREFIX) === 0;
142142
if (attribute) {
143143
if (hasReservedPrefix) {
144-
logger.log(LOG_LEVEL.WARN,
144+
logger.log(LOG_LEVEL.WARN,
145145
sprintf('Attribute %s unexpectedly has reserved prefix %s; using attribute ID instead of reserved attribute name.', attributeKey, RESERVED_ATTRIBUTE_PREFIX));
146146
}
147147
return attribute.id;
@@ -372,7 +372,7 @@ module.exports = {
372372
} else {
373373
// catching improperly formatted experiments
374374
logger.log(LOG_LEVEL.ERROR, sprintf(ERROR_MESSAGES.IMPROPERLY_FORMATTED_EXPERIMENT, MODULE_NAME, experimentKey));
375-
return null
375+
return null;
376376
}
377377
} catch (ex) {
378378
// catching experiment not in datafile

‎packages/optimizely-sdk/lib/core/project_config/index.tests.js

Lines changed: 49 additions & 49 deletions
Large diffs are not rendered by default.

‎packages/optimizely-sdk/lib/index.browser.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ module.exports = {
5656
}
5757
}
5858

59-
if (config.skipJSONValidation == null) {
59+
// Explicitly check for null or undefined
60+
if (config.skipJSONValidation == null) { // eslint-disable-line eqeqeq
6061
config.skipJSONValidation = true;
6162
}
6263

‎packages/optimizely-sdk/lib/index.browser.tests.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ describe('javascript-sdk', function() {
4141
xhr = sinon.useFakeXMLHttpRequest();
4242
global.XMLHttpRequest = xhr;
4343
requests = [];
44-
xhr.onCreate = function (xhr) {
45-
requests.push(xhr);
44+
xhr.onCreate = function (req) {
45+
requests.push(req);
4646
};
4747
});
4848

@@ -124,7 +124,7 @@ describe('javascript-sdk', function() {
124124
assert.strictEqual(didSetVariation, true);
125125

126126
var variation = optlyInstance.getForcedVariation('testExperiment', 'testUser');
127-
assert.strictEqual(variation, 'control')
127+
assert.strictEqual(variation, 'control');
128128
done();
129129
});
130130

@@ -140,13 +140,13 @@ describe('javascript-sdk', function() {
140140
assert.strictEqual(didSetVariation, true);
141141

142142
var variation = optlyInstance.getForcedVariation('testExperiment', 'testUser');
143-
assert.strictEqual(variation, 'control')
143+
assert.strictEqual(variation, 'control');
144144

145145
var didSetVariation2 = optlyInstance.setForcedVariation('testExperiment', 'testUser', null);
146146
assert.strictEqual(didSetVariation2, true);
147147

148148
var variation2 = optlyInstance.getForcedVariation('testExperiment', 'testUser');
149-
assert.strictEqual(variation2, null)
149+
assert.strictEqual(variation2, null);
150150
done();
151151
});
152152

@@ -166,10 +166,10 @@ describe('javascript-sdk', function() {
166166

167167

168168
var variation = optlyInstance.getForcedVariation('testExperiment', 'testUser');
169-
assert.strictEqual(variation, 'control')
169+
assert.strictEqual(variation, 'control');
170170

171171
var variation2 = optlyInstance.getForcedVariation('testExperimentLaunched', 'testUser');
172-
assert.strictEqual(variation2, 'controlLaunched')
172+
assert.strictEqual(variation2, 'controlLaunched');
173173
done();
174174
});
175175

@@ -191,10 +191,10 @@ describe('javascript-sdk', function() {
191191
assert.strictEqual(didSetVariation2, true);
192192

193193
var variation = optlyInstance.getForcedVariation('testExperiment', 'testUser');
194-
assert.strictEqual(variation, 'control')
194+
assert.strictEqual(variation, 'control');
195195

196196
var variation2 = optlyInstance.getForcedVariation('testExperimentLaunched', 'testUser');
197-
assert.strictEqual(variation2, null)
197+
assert.strictEqual(variation2, null);
198198
done();
199199
});
200200

@@ -216,10 +216,10 @@ describe('javascript-sdk', function() {
216216
assert.strictEqual(didSetVariation2, true);
217217

218218
var variation = optlyInstance.getForcedVariation('testExperiment', 'testUser');
219-
assert.strictEqual(variation, 'control')
219+
assert.strictEqual(variation, 'control');
220220

221221
var variation2 = optlyInstance.getForcedVariation('testExperimentLaunched', 'testUser');
222-
assert.strictEqual(variation2, 'variationLaunched')
222+
assert.strictEqual(variation2, 'variationLaunched');
223223
done();
224224
});
225225

@@ -235,13 +235,13 @@ describe('javascript-sdk', function() {
235235
assert.strictEqual(didSetVariation, true);
236236

237237
var variation = optlyInstance.getVariation('testExperiment', 'testUser');
238-
assert.strictEqual(variation, 'control')
238+
assert.strictEqual(variation, 'control');
239239

240240
var didSetVariation2 = optlyInstance.setForcedVariation('testExperiment', 'testUser', 'variation');
241241
assert.strictEqual(didSetVariation2, true);
242242

243243
var variation = optlyInstance.getVariation('testExperiment', 'testUser');
244-
assert.strictEqual(variation, 'variation')
244+
assert.strictEqual(variation, 'variation');
245245
done();
246246
});
247247

@@ -257,7 +257,7 @@ describe('javascript-sdk', function() {
257257
assert.strictEqual(didSetVariation, true);
258258

259259
var variation = optlyInstance.getVariation('testExperimentNotRunning', 'testUser');
260-
assert.strictEqual(variation, null)
260+
assert.strictEqual(variation, null);
261261

262262
done();
263263
});

‎packages/optimizely-sdk/lib/optimizely/index.tests.js

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ describe('lib/optimizely', function() {
291291
});
292292
bucketStub.returns('111129');
293293

294-
var activate = instance.activate('testExperiment', 'testUser');;
294+
var activate = instance.activate('testExperiment', 'testUser');
295295

296296
assert.strictEqual(activate, 'variation');
297297
eventDispatcherPromise.then(function() {
@@ -302,7 +302,7 @@ describe('lib/optimizely', function() {
302302
'testUser',
303303
'testExperiment'));
304304
done();
305-
})
305+
});
306306
});
307307

308308
it('should execute a custom dispatchEvent\'s promise in track', function(done) {
@@ -317,7 +317,7 @@ describe('lib/optimizely', function() {
317317
});
318318
bucketStub.returns('111129');
319319

320-
var activate = instance.activate('testExperiment', 'testUser');;
320+
var activate = instance.activate('testExperiment', 'testUser');
321321

322322
assert.strictEqual(activate, 'variation');
323323
instance.track('testEvent', 'testUser');
@@ -329,9 +329,9 @@ describe('lib/optimizely', function() {
329329
'testEvent',
330330
'testUser'));
331331
done();
332-
})
332+
});
333333
});
334-
})
334+
});
335335

336336
describe('APIs', function() {
337337
var optlyInstance;
@@ -662,7 +662,7 @@ describe('lib/optimizely', function() {
662662
sinon.assert.callCount(createdLogger.log, 3);
663663

664664
var logMessage0 = createdLogger.log.args[0][1];
665-
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION,'PROJECT_CONFIG','testUser'));
665+
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION, 'PROJECT_CONFIG', 'testUser'));
666666

667667
var logMessage1 = createdLogger.log.args[1][1];
668668
assert.strictEqual(logMessage1, sprintf(LOG_MESSAGES.USER_NOT_IN_EXPERIMENT, 'DECISION_SERVICE', 'testUser', 'testExperimentWithAudiences'));
@@ -676,7 +676,7 @@ describe('lib/optimizely', function() {
676676
sinon.assert.callCount(createdLogger.log, 3);
677677

678678
var logMessage0 = createdLogger.log.args[0][1];
679-
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION,'PROJECT_CONFIG','testUser'));
679+
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION, 'PROJECT_CONFIG', 'testUser'));
680680

681681
var logMessage1 = createdLogger.log.args[1][1];
682682
assert.strictEqual(logMessage1, sprintf(LOG_MESSAGES.USER_NOT_IN_EXPERIMENT, 'DECISION_SERVICE', 'testUser', 'groupExperiment1'));
@@ -776,7 +776,7 @@ describe('lib/optimizely', function() {
776776
sinon.assert.calledThrice(createdLogger.log);
777777

778778
var logMessage0 = createdLogger.log.args[0][1];
779-
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION,'PROJECT_CONFIG','user1'));
779+
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION, 'PROJECT_CONFIG', 'user1'));
780780
var logMessage1 = createdLogger.log.args[1][1];
781781
assert.strictEqual(logMessage1, sprintf(LOG_MESSAGES.USER_FORCED_IN_VARIATION, 'DECISION_SERVICE', 'user1', 'control'));
782782

@@ -1219,7 +1219,7 @@ describe('lib/optimizely', function() {
12191219

12201220
sinon.assert.callCount(createdLogger.log, 4);
12211221
var logMessage0 = createdLogger.log.args[0][1];
1222-
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION,'PROJECT_CONFIG','testUser'));
1222+
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION, 'PROJECT_CONFIG', 'testUser'));
12231223
var logMessage1 = createdLogger.log.args[1][1];
12241224
assert.strictEqual(logMessage1, sprintf(LOG_MESSAGES.USER_NOT_IN_EXPERIMENT, 'DECISION_SERVICE', 'testUser', 'testExperimentWithAudiences'));
12251225
var logMessage2 = createdLogger.log.args[2][1];
@@ -1242,7 +1242,7 @@ describe('lib/optimizely', function() {
12421242
optlyInstance.track('testEvent', 'testUser');
12431243
sinon.assert.notCalled(eventDispatcher.dispatchEvent);
12441244
var logMessage0 = createdLogger.log.args[0][1];
1245-
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION,'PROJECT_CONFIG','testUser'));
1245+
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION, 'PROJECT_CONFIG', 'testUser'));
12461246
var logMessage1 = createdLogger.log.args[1][1];
12471247
assert.strictEqual(logMessage1, sprintf(LOG_MESSAGES.NOT_TRACKING_USER_FOR_EXPERIMENT, 'OPTIMIZELY', 'testUser', 'testExperiment'));
12481248
});
@@ -1320,9 +1320,9 @@ describe('lib/optimizely', function() {
13201320
assert.deepEqual(eventDispatcherCall[0], expectedObj);
13211321

13221322
var logMessage0 = createdLogger.log.args[0][1];
1323-
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION,'PROJECT_CONFIG','testUser'));
1323+
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION, 'PROJECT_CONFIG', 'testUser'));
13241324
var logMessage1 = createdLogger.log.args[1][1];
1325-
assert.strictEqual(logMessage1, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION,'PROJECT_CONFIG','testUser'));
1325+
assert.strictEqual(logMessage1, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION, 'PROJECT_CONFIG', 'testUser'));
13261326
var logMessage2 = createdLogger.log.args[2][1];
13271327
assert.strictEqual(logMessage2, sprintf(LOG_MESSAGES.EXPERIMENT_NOT_RUNNING, 'DECISION_SERVICE', 'testExperimentNotRunning'));
13281328
var logMessage3 = createdLogger.log.args[3][1];
@@ -1421,7 +1421,7 @@ describe('lib/optimizely', function() {
14211421
sinon.assert.calledThrice(createdLogger.log);
14221422

14231423
var logMessage0 = createdLogger.log.args[0][1];
1424-
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION,'PROJECT_CONFIG','user1'));
1424+
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION, 'PROJECT_CONFIG', 'user1'));
14251425
var logMessage1 = createdLogger.log.args[1][1];
14261426
assert.strictEqual(logMessage1, sprintf(LOG_MESSAGES.USER_FORCED_IN_VARIATION, 'DECISION_SERVICE', 'user1', 'control'));
14271427

@@ -1524,7 +1524,7 @@ describe('lib/optimizely', function() {
15241524
sinon.assert.calledThrice(createdLogger.log);
15251525

15261526
var logMessage0 = createdLogger.log.args[0][1];
1527-
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION,'PROJECT_CONFIG','testUser'));
1527+
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION, 'PROJECT_CONFIG', 'testUser'));
15281528
var logMessage1 = createdLogger.log.args[1][1];
15291529
assert.strictEqual(logMessage1, sprintf(LOG_MESSAGES.USER_NOT_IN_EXPERIMENT, 'DECISION_SERVICE', 'testUser', 'testExperimentWithAudiences'));
15301530
var logMessage2 = createdLogger.log.args[2][1];
@@ -1591,7 +1591,7 @@ describe('lib/optimizely', function() {
15911591
sinon.assert.calledTwice(createdLogger.log);
15921592

15931593
var logMessage0 = createdLogger.log.args[0][1];
1594-
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION,'PROJECT_CONFIG','user1'));
1594+
assert.strictEqual(logMessage0, sprintf(LOG_MESSAGES.USER_HAS_NO_FORCED_VARIATION, 'PROJECT_CONFIG', 'user1'));
15951595
var logMessage = createdLogger.log.args[1][1];
15961596
assert.strictEqual(logMessage, sprintf(LOG_MESSAGES.USER_FORCED_IN_VARIATION, 'DECISION_SERVICE', 'user1', 'control'));
15971597
});

‎packages/optimizely-sdk/lib/plugins/event_dispatcher/index.browser.tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ describe('lib/plugins/event_dispatcher/browser', function() {
2727
xhr = sinon.useFakeXMLHttpRequest();
2828
global.XMLHttpRequest = xhr;
2929
requests = [];
30-
xhr.onCreate = function (xhr) {
31-
requests.push(xhr);
30+
xhr.onCreate = function (req) {
31+
requests.push(req);
3232
};
3333
});
3434

0 commit comments

Comments
 (0)