Skip to content

chore: fix all lint warnings #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2018
Merged

chore: fix all lint warnings #111

merged 2 commits into from
Jun 7, 2018

Conversation

tylerbrandt
Copy link
Contributor

@tylerbrandt tylerbrandt commented Jun 7, 2018

  • Use npm run lint -- --fix for most issues, and manually fix the rest

@tylerbrandt tylerbrandt requested a review from a team June 7, 2018 22:54
@@ -56,7 +56,8 @@ module.exports = {
}
}

if (config.skipJSONValidation == null) {
// Explicitly check for null or undefined
if (config.skipJSONValidation == null) { // eslint-disable-line eqeqeq
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up!

@tylerbrandt tylerbrandt merged commit c9f8953 into master Jun 7, 2018
@tylerbrandt tylerbrandt deleted the tyler/lint branch June 7, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants