Skip to content

fix: catch error that occurs when ghost user made a release. #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2025
Merged

fix: catch error that occurs when ghost user made a release. #367

merged 2 commits into from
Aug 30, 2025
+6 −0

Conversation

1ucian0
Copy link
Contributor

@1ucian0 1ucian0 commented Aug 29, 2025 •
edited by zkoppert
Loading

Tip

Basically, a port of github/issue-metrics#325 with almost exactly the same explanation in this PR

Pull Request

fixes #258

Proposed Changes

This pull request changes the get_days_since_last_release function in the stale_repos.py file. The change introduces error handling to deal with potential TypeError exceptions that might occur when processing a release. If such an error occurs, a message is printed to inform the user that the release might contain a ghost user, and None is returned.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

@1ucian0 1ucian0 requested a review from a team as a code owner August 29, 2025 23:36
@github-actions github-actions bot added the fix label Aug 29, 2025
@1ucian0 1ucian0 mentioned this pull request Aug 29, 2025
Closed
zkoppert
zkoppert approved these changes Aug 30, 2025
View reviewed changes
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!!

@zkoppert zkoppert enabled auto-merge August 30, 2025 03:48
@jmeridth jmeridth disabled auto-merge August 30, 2025 10:47
@jmeridth jmeridth merged commit c6e5fbe into github:main Aug 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeridth jmeridth jmeridth approved these changes

@zkoppert zkoppert zkoppert approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash whilst generating report
3 participants
@1ucian0 @jmeridth @zkoppert