Bump @octokit/rest from 21.1.1 to 22.0.0 in /extensions/ql-vscode #4114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 21.1.1 to 22.0.0. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](octokit/rest.js@v21.1.1...v22.0.0) --- updated-dependencies: - dependency-name: "@octokit/rest" dependency-version: 22.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
koesie10
reviewed
Aug 15, 2025
| @@ -26,15 +25,15 @@ export async function submitVariantAnalysis( | |||
| repository_owners: databases.repositoryOwners, | |||
| }; | |||
|
|
|||
| const response: OctokitResponse<VariantAnalysis> = await octokit.request( | |||
| const response = await octokit.request( | |||
There was a problem hiding this comment.
I think we're using the incorrect method of making the request, which is why this has stopped working. POST /repositories/:controllerRepoId/code-scanning/codeql/variant-analyses doesn't exist in the OpenAPI types (since it's listed as POST /repos/{owner}/{repo}/code-scanning/codeql/variant-analyses), so we should instead be using the single argument variant of the request method. Something like:
const response = await octokit.request<VariantAnalysis>({
method: "POST",
url: "/repositories/:controllerRepoId/code-scanning/codeql/variant-analyses",
controllerRepoId,
data,
});I haven't checked whether this actually works correctly, but it seems like that is cleaner and doesn't require us to cast an any to our custom type.
Comment on lines
+28
to
+33
| const response = await octokit.request<VariantAnalysis>({ | ||
| method: "POST", | ||
| url: "/repositories/:controllerRepoId/code-scanning/codeql/variant-analyses", | ||
| controllerRepoId, | ||
| data, | ||
| }); |
Check warning
Code scanning / CodeQL
File data in outbound network request Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps @octokit/rest from 21.1.1 to 22.0.0.
Release notes
Sourced from
@octokit/rest's releases.Commits
77530abfix(deps): update octokit monorepo (major) (#504)d07b719build(deps): Bump vite from 6.2.5 to 6.3.4 (#509)61b76dabuild(deps-dev): Bump http-proxy-middleware from 2.0.7 to 2.0.9 (#505)1710669chore(deps): update dependency undici to v6.21.2 [security] (#513)8ef1473build(deps): Bump vite from 6.0.11 to 6.2.5 (#503)1e8306bbuild(deps): Bump webpack-dev-middleware and gatsby in /docs (#497)3db0595build(deps): Bump send and express in /docs (#490)27f09ddbuild(deps-dev): Bump webpack from 5.93.0 to 5.98.0 in /docs (#494)005b147chore(deps): update dependency prismjs to v1.30.0 [security] (#493)3517730chore(deps): update dependency semantic-release-plugin-update-version-in-file...Most Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)