Restrict frontmatter schema with additionalProperties: false and align with GitHub Actions schema #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…false - Updated main_workflow_schema.json to set additionalProperties: false at all object levels - Added missing standard GitHub Actions properties (defaults, jobs, new permissions) - Enhanced permissions schema to match official GitHub Actions specification - Added missing trigger types (pull_request_review_comment) - Fixed tools configuration to support MCP-specific properties - Expanded test coverage with comprehensive validation tests for additional properties - All existing functionality preserved with improved validation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot finished work on behalf of
pelikhan
August 20, 2025 07:16
dsyme
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR strengthens the validation of frontmatter schemas by setting
additionalProperties: falseat all object levels and aligning allowed keys with the official GitHub Actions schema. Previously, several types allowed additional properties, resulting in weak validation and acceptance of unexpected keys.Key Changes
Enhanced Schema Validation
additionalProperties: falseat all object levels inmain_workflow_schema.jsonGitHub Actions Schema Alignment
defaults,jobsattestations,id-token,packages,pages,repository-projectspull_request_review_commentread-all,write-all)Project-Specific Extensions
engine,tools,claude,cache,output, etc.use_docker_mcp,docker_image_version)claudeconfiguration to supportallowedproperty structurestepsandpost-stepsto support both object and array formatsComprehensive Test Coverage
Example
Before this change, invalid frontmatter like this would pass validation:
After this change, the schema properly rejects these invalid properties with clear error messages:
Backwards Compatibility
All existing workflows continue to work without changes. The enhanced validation only rejects truly invalid configurations while maintaining full support for:
Fixes #131.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.contoso.com/tmp/go-build1090515667/b278/cli.test -test.testlogfile=/tmp/go-build1090515667/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)/tmp/go-build988858831/b278/cli.test -test.testlogfile=/tmp/go-build988858831/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)/tmp/go-build3175447768/b278/cli.test -test.testlogfile=/tmp/go-build3175447768/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true(dns block)www.schemastore.orgcurl -s REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.