-
Notifications
You must be signed in to change notification settings - Fork 6
Fix test-proxy.md to use automatic comment creation instead of manual GitHub tools #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test-proxy.md to use automatic comment creation instead of manual GitHub tools #190
Conversation
|
You could win a turn by also inline the pr number in the template |
@copilot can you resolve the comments above? |
Removed
Added the inline PR number template
All comments have been addressed:
The workflow now uses the output mechanism for automatic comment creation with proper permissions. Changes committed in 43102c4. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com>
…eview comments Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
43102c4
to
6e0a957
Compare
Problem
The
test-proxy.md
workflow was incorrectly configured to manually handle GitHub comment creation, which is unnecessary when using theoutput: issue_comment: {}
mechanism. This resulted in:create_comment
tool permissions that weren't neededSolution
Updated the workflow to properly use the automatic comment creation mechanism:
Before:
After:
Key Changes
Removed redundant create_comment tool: The
output: issue_comment: {}
mechanism automatically handles comment creation, making the manual tool unnecessaryAutomatic permission handling: Replaced manual
permissions: issues: write
with the output mechanism that automatically provides appropriateissues: write
andpull-requests: write
permissions only to the comment jobAdded inline PR number: Included
${{ github.event.pull_request.number }}
in the reporting instructions for better contextCleaner architecture: The main workflow job no longer needs write permissions, improving security by following the principle of least privilege
Benefits
The compiled workflow now generates a properly isolated
create_issue_comment
job that runs conditionally when there's output to share.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.