Fix Git.{AutoInterrupt,CatFileContentStream} static typing #2039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2038
This fixes
mypy
forGit.AutoInterrupt
andGit.CatFileContentStream
. Static type checking of these was broken inadvertently in #2037, as described in #2038. This is approach (2) described in #2038. Further details are in that bug report and in the commit messages.As in #2037, I've made sure this doesn't break Sphinx (though it would be very strange if it did), by checking locally as well as in the RTD cloud build. The entries in the latter can be examined:
AutoInterrupt
,CatFileContentStream
.Because CI runs
mypy
but does not verify its output, I'll wait to mark this non-draft until I've looked at all relevant jobs'mypy
steps. (But this may be before the jobs complete, since the jobs that runmypy
do so before runningpytest
, not after.)Edit: All
mypy
results on CI look as they did before, and then new errors that came in with #2037 are gone.