Skip to content

Clarify USE_SHELL warning helper signature #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025
Merged

Clarify USE_SHELL warning helper signature #2045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions git/cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ def __del__(self) -> None:
)


def _warn_use_shell(extra_danger: bool) -> None:
def _warn_use_shell(*, extra_danger: bool) -> None:
warnings.warn(
_USE_SHELL_DANGER_MESSAGE if extra_danger else _USE_SHELL_DEFAULT_MESSAGE,
DeprecationWarning,
Expand All @@ -566,12 +566,12 @@ class _GitMeta(type):

def __getattribute(cls, name: str) -> Any:
if name == "USE_SHELL":
_warn_use_shell(False)
_warn_use_shell(extra_danger=False)
return super().__getattribute__(name)

def __setattr(cls, name: str, value: Any) -> Any:
if name == "USE_SHELL":
_warn_use_shell(value)
_warn_use_shell(extra_danger=value)
super().__setattr__(name, value)

if not TYPE_CHECKING:
Expand Down Expand Up @@ -988,7 +988,7 @@ def __init__(self, working_dir: Union[None, PathLike] = None) -> None:

def __getattribute__(self, name: str) -> Any:
if name == "USE_SHELL":
_warn_use_shell(False)
_warn_use_shell(extra_danger=False)
return super().__getattribute__(name)

def __getattr__(self, name: str) -> Any:
Expand Down
Loading