Do not rebuild gotip if the HEAD does not change #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

tie wants to merge 1 commit into golang:master from tie:master

+39 −1

tie commented May 24, 2020

On successful build a sentinel zero-byte file is written,
similar to .unpacked-success in internal/version. If this
file exists on next gotip download, compare HEADs before
and after FETCH_HEAD checkout, and trigger the build iff
they differ. In that case, sentinel file is removed to
make git clean happy and indicate that rebuild is needed.


          Do not rebuild gotip if the HEAD does not change

cb27fed

On successful build a sentinel zero-byte file is written,
similar to .unpacked-success in internal/version. If such
file exists on next gotip download, compare HEADs before
and after FETCH_HEAD checkout, and trigger the build iff
they differ. In that case, sentinel file is removed to
make git clean happy and indicate that rebuild is needed.

googlebot added the cla: yes label

Contributor

gopherbot commented May 24, 2020

This PR (HEAD: cb27fed) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/dl/+/235117 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Sep 11, 2020

Message from Dmitri Shuralyov:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/235117.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 11, 2020

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=07cdb593

Please don’t reply on this GitHub thread. Visit golang.org/cl/235117.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 11, 2020

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/235117.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 15, 2020

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=07cdb593

Please don’t reply on this GitHub thread. Visit golang.org/cl/235117.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 15, 2020

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/235117.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 8, 2021

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=07cdb593

Please don’t reply on this GitHub thread. Visit golang.org/cl/235117.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 8, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/235117.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels