all: enhance CLAUDE.md with test verification and release build requirements #6113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutter
requested changes
Aug 20, 2025
CLAUDE.md
Outdated
| @@ -103,11 +119,15 @@ cargo fmt --all | |||
|
|
|||
| # 🚨 MANDATORY: Check code for warnings and errors - MUST have zero warnings | |||
| cargo check | |||
|
|
|||
| # 🚨 MANDATORY: Build in release mode to catch linking/optimization issues that cargo check misses | |||
| cargo build --release | |||
There was a problem hiding this comment.
Release builds are really slow. Wouldn't cargo check --release be enough here? That can sometimes fail because of conditional compilation, but I've never seen a linking/optimization error.
There was a problem hiding this comment.
I have no idea. I just noticed that I was getting build errors in CI sometimes despite cargo check passing.
There was a problem hiding this comment.
Will ask claude to adjust with your feedback later
There was a problem hiding this comment.
I just changed it to cargo check --release for now so I can merge this
…rements Add explicit test verification requirements to prevent false test successes: - Verify tests actually ran by checking output for "X passed" where X > 0 - Never trust exit code 0 alone as cargo can exit successfully with 0 tests run - Re-run with corrected filters if no tests were executed Add mandatory cargo build --release step to catch linking/optimization issues that cargo check might miss, preventing CI build failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
lutter
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cargo build --releasestep to catch linking/optimization issues thatcargo checkmight missTest plan
🤖 Generated with Claude Code