Skip to content

use 'var' in Actions #10776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 18, 2025
Merged

use 'var' in Actions #10776

merged 4 commits into from
Aug 18, 2025

Conversation

gavinking
Copy link
Member

[Please describe here what your change is about]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Aug 18, 2025 •
edited
Loading

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [a63ae70, c908efa, 4e9bcf8, 3c0c653]

› This message was automatically generated.

@gavinking gavinking marked this pull request as ready for review August 18, 2025 08:37
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 18, 2025
View reviewed changes
hibernate-core/src/main/java/org/hibernate/action/internal/EntityDeleteAction.java
boolean veto = false;
for ( PreDeleteEventListener listener : listenerGroup.listeners() ) {
for ( var listener : listenerGroup.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/action/internal/EntityDeleteAction.java
@@ -252,7 +242,7 @@

@Override
protected boolean hasPostCommitEventListeners() {
for ( PostDeleteEventListener listener: getEventListenerGroups().eventListenerGroup_POST_COMMIT_DELETE.listeners() ) {
for ( var listener: getEventListenerGroups().eventListenerGroup_POST_COMMIT_DELETE.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/action/internal/EntityIdentityInsertAction.java
= getEventListenerGroups().eventListenerGroup_POST_COMMIT_INSERT;
for ( PostInsertEventListener listener : group.listeners() ) {
final var group = getEventListenerGroups().eventListenerGroup_POST_COMMIT_INSERT;
for ( var listener : group.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/action/internal/EntityIdentityInsertAction.java
boolean veto = false;
for ( PreInsertEventListener listener : listenerGroup.listeners() ) {
for ( var listener : listenerGroup.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/action/internal/EntityInsertAction.java
for ( PreInsertEventListener listener : listenerGroup.listeners() ) {
final PreInsertEvent event =
new PreInsertEvent( getInstance(), getId(), getState(), getPersister(), eventSource() );
for ( var listener : listenerGroup.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/action/internal/EntityInsertAction.java
= getEventListenerGroups().eventListenerGroup_POST_COMMIT_INSERT;
for ( PostInsertEventListener listener : group.listeners() ) {
final var group = getEventListenerGroups().eventListenerGroup_POST_COMMIT_INSERT;
for ( var listener : group.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/action/internal/EntityUpdateAction.java
if ( listenerGroup.isEmpty() ) {
return false;
}
else {
final PreUpdateEvent event =
new PreUpdateEvent( getInstance(), getId(), state, previousState, getPersister(), eventSource() );
boolean veto = false;
for ( PreUpdateEventListener listener : listenerGroup.listeners() ) {
for ( var listener : listenerGroup.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/action/internal/EntityUpdateAction.java
= getEventListenerGroups().eventListenerGroup_POST_COMMIT_UPDATE;
for ( PostUpdateEventListener listener : group.listeners() ) {
final var group = getEventListenerGroups().eventListenerGroup_POST_COMMIT_UPDATE;
for ( var listener : group.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
Loading
should be avoided because it has been deprecated.
@gavinking gavinking merged commit 23b9b8f into hibernate:main Aug 18, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gavinking